From fb309613cd50fd97e66d095956335f8ce76aa2db Mon Sep 17 00:00:00 2001
From: Wouter Deconinck <wdconinc@gmail.com>
Date: Mon, 4 Mar 2024 15:15:04 -0600
Subject: [PATCH] fix: rm unused TrackProjectorConfig (#1319)

### Briefly, what does this PR introduce?
This PR removes the unused TrackProjectorConfig stuct. Instead of
expanding the use of this algorithm, we should be focusing on
TrackPropagation for filling track segments.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: unused config struct)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
---
 src/algorithms/tracking/TrackProjector.h      |  4 +---
 .../tracking/TrackProjectorConfig.h           | 19 -------------------
 src/global/tracking/TrackProjector_factory.h  |  4 +---
 3 files changed, 2 insertions(+), 25 deletions(-)
 delete mode 100644 src/algorithms/tracking/TrackProjectorConfig.h

diff --git a/src/algorithms/tracking/TrackProjector.h b/src/algorithms/tracking/TrackProjector.h
index 771a5f27ff..d1aa9fa5d2 100644
--- a/src/algorithms/tracking/TrackProjector.h
+++ b/src/algorithms/tracking/TrackProjector.h
@@ -11,7 +11,6 @@
 #include <vector>
 
 #include "ActsGeometryProvider.h"
-#include "TrackProjectorConfig.h"
 #include "algorithms/interfaces/WithPodConfig.h"
 
 
@@ -21,8 +20,7 @@ namespace eicrecon {
          *
          * \ingroup tracking
          */
-        class TrackProjector:
-                public eicrecon::WithPodConfig<TrackProjectorConfig> {
+        class TrackProjector {
 
         public:
 
diff --git a/src/algorithms/tracking/TrackProjectorConfig.h b/src/algorithms/tracking/TrackProjectorConfig.h
deleted file mode 100644
index 651cc57080..0000000000
--- a/src/algorithms/tracking/TrackProjectorConfig.h
+++ /dev/null
@@ -1,19 +0,0 @@
-// Created by Dmitry Romanov
-// Subject to the terms in the LICENSE file found in the top-level directory.
-//
-
-#pragma once
-
-#include <string>
-
-namespace eicrecon {
-
-    struct TrackProjectorConfig {
-        unsigned int m_firstInVolumeID;
-        std::string m_firstInVolumeName;
-        float m_firstSmallerThanZ;
-        float m_firstGreaterThanZ;
-        float m_firstGreaterThanR;
-    };
-
-} // eicrecon
diff --git a/src/global/tracking/TrackProjector_factory.h b/src/global/tracking/TrackProjector_factory.h
index c64e5e528a..df40444054 100644
--- a/src/global/tracking/TrackProjector_factory.h
+++ b/src/global/tracking/TrackProjector_factory.h
@@ -13,13 +13,12 @@
 #include <vector>
 
 #include "algorithms/tracking/TrackProjector.h"
-#include "algorithms/tracking/TrackProjectorConfig.h"
 #include "extensions/jana/JOmniFactory.h"
 
 namespace eicrecon {
 
 class TrackProjector_factory :
-        public JOmniFactory<TrackProjector_factory, TrackProjectorConfig> {
+        public JOmniFactory<TrackProjector_factory> {
 
 private:
     using AlgoT = eicrecon::TrackProjector;
@@ -33,7 +32,6 @@ class TrackProjector_factory :
 public:
     void Configure() {
         m_algo = std::make_unique<AlgoT>();
-        m_algo->applyConfig(config());
         m_algo->init(m_ACTSGeoSvc().actsGeoProvider(), logger());
     }