New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire support for compiling in old eic containers #1705

Open

veprbl opened this issue Jan 15, 2025 · 1 comment

Member

veprbl commented Jan 15, 2025

We currently support unreasonable amount of backwards compatibility

EICrecon/.github/workflows/linux-eic-shell.yml

Lines 89 to 95 in d96cbff

    
           - CC: clang 
        
             CXX: clang++ 
        
             CMAKE_BUILD_TYPE: Release 
        
             release: 24.04.0-stable 
        
           - CC: clang 
        
             CMAKE_BUILD_TYPE: Release 
        
             release: 24.05.2-stable

Suggestion is to look into updating those versions and removing some of the #ifs that are not needed after that.

The text was updated successfully, but these errors were encountered:

Contributor

wdconinc commented Jan 15, 2025

6 months?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment