Enable Link-Time Optimization (LTO)

[zamazan4ik]

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

Thank you.

P.S. It's more like an improvement idea rather than a bug. I created the issue just because the Discussions are disabled for the repo for now.

[sergey-melnychuk]

Hi @zamazan4ik , thank you for the suggestion!

I see no harm in enabling LTO for the release build and more compact binary seems like a reasonable trade off for a slightly longer compilation time, so once #812 is merged I'll just run release 0.6.1 and this should be enough to make LTO enabled by default for cargo install etc.

I wouldn't expect significant performance improvements from enabling LTO though, as general Beerus workload turns out to be rather IO-bound.