Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market Pallet: reconsider publish_storage_deals design #121

Closed
Tracked by #162
th7nder opened this issue Jul 8, 2024 · 0 comments · Fixed by #599
Closed
Tracked by #162

Market Pallet: reconsider publish_storage_deals design #121

th7nder opened this issue Jul 8, 2024 · 0 comments · Fixed by #599
Assignees
@aidan46
Labels
pallet-market Relates to the Market Pallet research tech debt Flags technical debt
Milestone
Phase 3

Comments

@th7nder
Copy link
Contributor

th7nder commented Jul 8, 2024 •
edited by jmg-duarte
Loading

#105 (comment)

The issue is that the function fails silently in a lot of cases, by just not emitting the event for the respective deal.
We need to decided if we want to keep this design decision or if all deals must be valid.

Related:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aidan46 aidan46

Labels
pallet-market Relates to the Market Pallet research tech debt Flags technical debt
Projects
None yet
Milestone
Phase 3
Development

Successfully merging a pull request may close this issue.

refactor: Publish storage deals eigerco/polka-storage
3 participants
@th7nder @jmg-duarte @aidan46