Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests: error handling with publish_storage_deals #138

Closed
th7nder opened this issue Jul 17, 2024 · 0 comments · Fixed by #153
Closed

Integration Tests: error handling with publish_storage_deals #138

th7nder opened this issue Jul 17, 2024 · 0 comments · Fixed by #153
Labels
bug Something isn't working
Milestone

Comments

@th7nder
Copy link
Contributor

th7nder commented Jul 17, 2024

  • Logs show wasm:stripped in some places:
2024-07-16 10:43:36.021 ERROR tokio-runtime-worker runtime::market: [Parachain] insane deal: idx 0, error: <wasm:stripped>   

It happens, because:

    #[derive(RuntimeDebug)]
    pub enum ProposalError {
    

So the debug is not implemented in WASM.

 log::error!(target: LOG_TARGET, "insane deal: idx {}, error: {:?}", idx, e);

Possible solutions:

On the other hand...
This error design of publish_storage_deals sucks (#121), from the user perspective.

Originally posted by @th7nder in #108 (comment)

Main goal is to make sure that the final user is able to understand what went wrong without looking into the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants