Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI benchmarks test #28

Closed
1 task
serg-temchenko opened this issue May 16, 2024 · 1 comment · Fixed by #702
Closed
1 task

CI benchmarks test #28

serg-temchenko opened this issue May 16, 2024 · 1 comment · Fixed by #702
Assignees
Labels
devops enhancement New feature or request frozen PR/Issue is on hold research

Comments

@serg-temchenko
Copy link
Contributor

  • - To catch bugs with benchmarks in Substrate, it is also required to run a simple pass on benchmarks, e.g. ./target/debug/polka-storage-node benchmark pallet --pallet "" --extrinsic "" --steps 2 --repeat 1

Still to be implemented when we will have some pallets to test.

Related to #3.

@serg-temchenko serg-temchenko added the enhancement New feature or request label May 16, 2024
@serg-temchenko serg-temchenko mentioned this issue May 16, 2024
8 tasks
aidan46 added a commit that referenced this issue May 21, 2024
It is required to run a simple pass on benchmarks to catch bugs.

Fixes #28
@jmg-duarte jmg-duarte added the frozen PR/Issue is on hold label Sep 10, 2024
@jmg-duarte
Copy link
Collaborator

With benchmarks v2 cargo test --features runtime-benchmarks -- benchmark or something very similar should be enough, I'll add this to our CI in the upcoming benchmark PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops enhancement New feature or request frozen PR/Issue is on hold research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants