Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] address feedback from Polkadot forum #606

Open
9 of 10 tasks
jmg-duarte opened this issue Nov 25, 2024 · 0 comments
Open
9 of 10 tasks

[tracking] address feedback from Polkadot forum #606

jmg-duarte opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
tracking Tracking issue
Milestone

Comments

@jmg-duarte
Copy link
Collaborator

jmg-duarte commented Nov 25, 2024

Forum comment: https://forum.polkadot.network/t/polkadot-native-storage-updates/7021/44

🚒 Urgent

  • Errors exposed to the user are not informative (WIP already, but not done yet) - refactor: Publish storage deals #599
  • The docs are still being improved and, in the current iteration, may be confusing (in short, installation/setup workflow is confusing — needs more info
  • The docs are out of sync with the repo, which made me waste 1-2 hours until I discovered that). This will be improved as well. Binaries/containers are out of sync with the docs as well (e.g. the faucet command) — docs are ahead, we need to rebuild the binaries
  • The repo defaults to develop but the docs refer to releases and some PRs with fixes don’t have useful recent commits, while latest release (and therefore, containers) has a 3 week old release) — write a banner in the README stating that main has the "stable" build
  • Publish deal RPC error is confusing — fix(storage-provider-server): better error message for missing deal proposal #607

⚠️ Important

  • More info about max size of blobs that can be PUT
  • GET steps (there are none, but we need to document that)
  • I wonder if there will be a way to differentiate public vs. private access
  • Recommended approach to encrypt objects, in the case public access be the default (I can’t tell if it will or won’t, since GET step isn’t in the docs right now)
  • It’s not very clear - although it didn’t impact my evaluation - if it’s OK to submit and sign a proposal before start_block as long as it’s not published before it. I wouldn’t expect that PUT can be performed before start_block, but maybe other steps can although, even in that case, the question is how much before start_block (i.e. N-14400, N-256, etc.)
@jmg-duarte jmg-duarte added the tracking Tracking issue label Nov 25, 2024
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Nov 25, 2024
@jmg-duarte jmg-duarte pinned this issue Nov 25, 2024
@jmg-duarte jmg-duarte self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking Tracking issue
Projects
None yet
Development

No branches or pull requests

1 participant