refactor: Publish storage deals #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
force-pushed
the
121-market-pallet-reconsider-publish_storage_deals-design
branch
from
e678867 to
6fb9f83
Compare
aidan46
force-pushed
the
121-market-pallet-reconsider-publish_storage_deals-design
branch
from
6fb9f83 to
222c0fa
Compare
This was
linked to
issues
Nov 22, 2024
aidan46
added
ready for review
aidan46
added
ready for review
aidan46
force-pushed
the
121-market-pallet-reconsider-publish_storage_deals-design
branch
from
15cdf3e to
fca5379
Compare
aidan46
added
ready for review
Refactor publish storage deals to fail if any deals are invalid and report the error to the user
10 tasks
aidan46
force-pushed
the
121-market-pallet-reconsider-publish_storage_deals-design
branch
from
25c9404 to
49b976f
Compare
aidan46
added
ready for review
jmg-duarte
reviewed
Nov 25, 2024
Merged
jmg-duarte
added
ready for review
th7nder
previously approved these changes
Nov 25, 2024
cernicc
requested changes
Nov 25, 2024
th7nder
previously approved these changes
Nov 25, 2024
aidan46
added
ready for review
th7nder
previously approved these changes
Nov 25, 2024
aidan46
added
ready for review
aidan46
added
ready for review
cernicc
approved these changes
Nov 25, 2024
th7nder
approved these changes
Nov 25, 2024
aidan46
deleted the
121-market-pallet-reconsider-publish_storage_deals-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor publish storage deals to fail if any deals are invalid and report the error to the user. Publishing storage deals now fails if a single deal is invalid and the error is relayed to the user. The tests have been updated to reflect the change. The success test for publish storage deals needed to be updated as there were not enough funds allocated, making 1 out of 3 deals fail. As a result of this we need to increase the initial balance and adapt the tests to take this into consideration.