Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mater): add mater::ReadOnlyBlockstore #774

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

jmg-duarte
Copy link
Collaborator

@jmg-duarte jmg-duarte commented Feb 21, 2025

Description

Adds CarReadOnlyBlockstore (still looking for better names, but there still needs to be a PR finishing organizing this chaos).

Doesn't remove the FileBlockstore just yet because we still need the read and write blockstore.

Requires #773

@jmg-duarte jmg-duarte self-assigned this Feb 21, 2025
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Feb 21, 2025
th7nder
th7nder previously approved these changes Feb 23, 2025
cernicc
cernicc previously approved these changes Feb 24, 2025
@jmg-duarte jmg-duarte added the ready for review Review is needed label Feb 24, 2025
@jmg-duarte jmg-duarte dismissed stale reviews from cernicc and th7nder via 610ab73 February 24, 2025 09:30
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@jmg-duarte jmg-duarte changed the title feat(mater): add CarReadOnlyBlockstore feat(mater): add mater::ReadOnlyBlockstore Feb 24, 2025
@jmg-duarte jmg-duarte force-pushed the feat/mater/blockstore branch from 388be2a to 3473dfb Compare February 24, 2025 10:49
@jmg-duarte jmg-duarte enabled auto-merge (squash) February 24, 2025 10:50
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@jmg-duarte jmg-duarte merged commit 74aacb4 into develop Feb 24, 2025
6 of 12 checks passed
@jmg-duarte jmg-duarte deleted the feat/mater/blockstore branch February 24, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants