Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: delia replication #776

Merged
merged 13 commits into from
Feb 25, 2025
Merged

rfc: delia replication #776

merged 13 commits into from
Feb 25, 2025

Conversation

pete-eiger
Copy link
Contributor

RFC for #742

@pete-eiger pete-eiger self-assigned this Feb 23, 2025
@pete-eiger pete-eiger added rfc Request for Comments (RFC) ready for review Review is needed labels Feb 23, 2025
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right direction, some minor comments.

@pete-eiger pete-eiger requested a review from aidan46 February 24, 2025 14:00
@pete-eiger
Copy link
Contributor Author

seems like the team is preferring the default "selection algorithm" to select for the cheapest N number (user provided value) of storage providers. This will be the default.

Of course if for some reason the user is not happy with this automatic selection, they will be able to select/deselect from the list of providers.

@pete-eiger pete-eiger requested a review from a team February 24, 2025 14:11
@pete-eiger pete-eiger added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@pete-eiger pete-eiger added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@pete-eiger pete-eiger added ready for review Review is needed and removed ready for review Review is needed labels Feb 24, 2025
@pete-eiger pete-eiger added ready for review Review is needed and removed ready for review Review is needed labels Feb 25, 2025
@pete-eiger pete-eiger enabled auto-merge (squash) February 25, 2025 12:55
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pete-eiger pete-eiger merged commit 37c3779 into develop Feb 25, 2025
10 of 12 checks passed
@pete-eiger pete-eiger deleted the rfc/742-delia-replication branch February 25, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed rfc Request for Comments (RFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants