-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pvm accumulate invocation #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greywolve
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have enough context for a very thorough review but looks reasonable. Just need to fix the linting issues.
Ah nm this is just a WIP |
e710d22
to
71106ac
Compare
71106ac
to
f8057d3
Compare
f8057d3
to
774d4e6
Compare
bamzedev
reviewed
Oct 30, 2024
I just checked the polkavm side for variable names. Can we not use |
67fc4d2
to
dd2ba51
Compare
dd2ba51
to
55b83f5
Compare
bamzedev
reviewed
Oct 31, 2024
carlos-romano
previously approved these changes
Oct 31, 2024
55b83f5
to
b077bf6
Compare
carlos-romano
approved these changes
Oct 31, 2024
bamzedev
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gray paper section B.4