Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pvm accumulate invocation #97

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

danielvladco
Copy link
Member

Gray paper section B.4

@danielvladco danielvladco requested a review from a team October 29, 2024 15:54
@danielvladco danielvladco self-assigned this Oct 29, 2024
@danielvladco danielvladco changed the title feat: add pvm accumulate invocation feat: add pvm accumulate invocation [WIP] Oct 29, 2024
greywolve
greywolve previously approved these changes Oct 30, 2024
Copy link
Contributor

@greywolve greywolve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have enough context for a very thorough review but looks reasonable. Just need to fix the linting issues.

@greywolve
Copy link
Contributor

Ah nm this is just a WIP

@danielvladco danielvladco force-pushed the feat/pvm-accumulate-invocation branch 2 times, most recently from e710d22 to 71106ac Compare October 30, 2024 15:06
@danielvladco danielvladco force-pushed the feat/pvm-accumulate-invocation branch from 71106ac to f8057d3 Compare October 30, 2024 15:12
@danielvladco danielvladco changed the title feat: add pvm accumulate invocation [WIP] feat: add pvm accumulate invocation Oct 30, 2024
@danielvladco danielvladco force-pushed the feat/pvm-accumulate-invocation branch from f8057d3 to 774d4e6 Compare October 30, 2024 15:13
@danielvladco danielvladco requested review from a team and greywolve October 30, 2024 15:14
@bamzedev
Copy link
Contributor

I just checked the polkavm side for variable names. Can we not use a, s, bb etc?

@danielvladco danielvladco force-pushed the feat/pvm-accumulate-invocation branch from 67fc4d2 to dd2ba51 Compare October 31, 2024 07:10
@danielvladco danielvladco requested a review from bamzedev October 31, 2024 07:36
@danielvladco danielvladco force-pushed the feat/pvm-accumulate-invocation branch from dd2ba51 to 55b83f5 Compare October 31, 2024 08:15
carlos-romano
carlos-romano previously approved these changes Oct 31, 2024
@danielvladco danielvladco merged commit 7832dcf into main Oct 31, 2024
2 checks passed
@danielvladco danielvladco deleted the feat/pvm-accumulate-invocation branch October 31, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants