Skip to content

Commit

Permalink
fix(ci): split release and review jobs into different workflows
Browse files Browse the repository at this point in the history
This fixes goreleaser failing on PRs
  • Loading branch information
Hashem Hashem authored and hashemmm96 committed Jan 10, 2023
1 parent 21fe294 commit a739f46
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 21 deletions.
24 changes: 3 additions & 21 deletions .github/workflows/ci.yml → .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
name: CI
name: Release

on:
push:
branches:
- master
pull_request:
branches:
- "*"

jobs:
make:
release:
runs-on: ubuntu-latest

steps:
- name: Setup Sage
uses: einride/sage/actions/setup@master
Expand All @@ -20,22 +18,6 @@ jobs:
- name: Make
run: make

- name: Report Code Coverage
uses: codecov/[email protected]
with:
file: ./build/coverage/go-test.txt
fail_ci_if_error: true

release:
needs: [make]
runs-on: ubuntu-latest

steps:
- name: Setup Sage
uses: einride/sage/actions/setup@master
with:
go-version: 1.19

- name: Create Release
uses: go-semantic-release/[email protected]
with:
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Review

on:
pull_request:

jobs:
make:
runs-on: ubuntu-latest
steps:
- name: Setup Sage
uses: einride/sage/actions/setup@master
with:
go-version: 1.19

- name: Make
run: make

- name: Report Code Coverage
uses: codecov/[email protected]
with:
file: ./build/coverage/go-test.txt
fail_ci_if_error: true

0 comments on commit a739f46

Please sign in to comment.