You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
When using buf to generate TypeScript HTTP code from .proto files, the max_price field defined as google.type.Decimal in FilterConditions is not being generated in the TypeScript code. This issue does not occur when google.type.Decimal is replaced with string. The problem seems specific to the handling of google.type.Decimal type for the max_price field.
Environment
Go version: 1.21.4 darwin/arm64
TypeScript version: Version 5.1.3
OS: Darwin & Ubuntu
Steps to Reproduce
Define min_price and max_price fields in FilterConditions message in common.proto using google.type.Decimal.
Generate TypeScript code using buf.gen.yaml configuration.
Observe that only minPrice is generated correctly in TypeScript, while maxPrice is missing.
Expected Behavior
Both minPrice and maxPrice fields should be generated in the TypeScript code, similar to how they are generated when defined as string types.
Actual Behavior
Only the minPrice field is generated in the TypeScript code. The maxPrice field is missing when using google.type.Decimal type.
Additional Information
admin.proto and common.proto files used for generating code.
buf.gen.yaml configuration file.
Examples of generated code with min_price and max_price as google.type.Decimal and as string.
Example Files
The text was updated successfully, but these errors were encountered:
jekabolt
changed the title
Missing ' Field in Generated TypeScript Code Using buf with google.type.Decimal
Missing Field in Generated TypeScript Code Using buf with google.type.Decimal
Dec 12, 2023
jekabolt
changed the title
Missing Field in Generated TypeScript Code Using buf with google.type.Decimal
Missing field in Generated TypeScript Code Using buf with google.type.Decimal
Dec 12, 2023
jekabolt
changed the title
Missing field in Generated TypeScript Code Using buf with google.type.Decimal
[Bug] Missing field in Generated TypeScript Code Using buf with google.type.Decimal
Dec 12, 2023
Description
When using buf to generate TypeScript HTTP code from .proto files, the max_price field defined as google.type.Decimal in FilterConditions is not being generated in the TypeScript code. This issue does not occur when google.type.Decimal is replaced with string. The problem seems specific to the handling of google.type.Decimal type for the max_price field.
Environment
Go version: 1.21.4 darwin/arm64
TypeScript version: Version 5.1.3
OS: Darwin & Ubuntu
Steps to Reproduce
Define min_price and max_price fields in FilterConditions message in common.proto using google.type.Decimal.
Generate TypeScript code using buf.gen.yaml configuration.
Observe that only minPrice is generated correctly in TypeScript, while maxPrice is missing.
Expected Behavior
Both minPrice and maxPrice fields should be generated in the TypeScript code, similar to how they are generated when defined as string types.
Actual Behavior
Only the minPrice field is generated in the TypeScript code. The maxPrice field is missing when using google.type.Decimal type.
Additional Information
admin.proto and common.proto files used for generating code.
buf.gen.yaml configuration file.
Examples of generated code with min_price and max_price as google.type.Decimal and as string.
Example Files
test.proto
buf.gen.yaml
generated code with min/max google.type.Decimal
generated code with min/max string
The text was updated successfully, but these errors were encountered: