Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple libraries crashes WaveBox #129

Open
benjmiller86 opened this issue Jul 19, 2013 · 18 comments
Open

Multiple libraries crashes WaveBox #129

benjmiller86 opened this issue Jul 19, 2013 · 18 comments
Assignees
Labels

Comments

@benjmiller86
Copy link

WaveBox crashes after startup if using multiple libraries. Web UI doesn't load either.

Syntax seems to looks okay in config. I have tried both of these with same results:

"mediaFolders": ["/Volumes/OAKWOOD/FLAC/","/Volumes/OAKWOOD/MP3/"],
"mediaFolders": ["/Volumes/OAKWOOD/FLAC","/Volumes/OAKWOOD/MP3"],

Here is my log. Is pastie the best way to do this?

http://pastie.org/8156586

@mdlayher
Copy link
Contributor

Looks like the native fsevents stuff for OSX that @einsteinx2 was working on.

http://gist.github.com/ is a good place to post logs, because there is no wrapping of lines, which makes output a little bit cluttered.

@einsteinx2
Copy link
Owner

Ya I'm probably not sending the array correctly to the unmanaged code or something. I'll fix it.

@einsteinx2
Copy link
Owner

I think this is fixed now. @benjmiller86 can you pull and build and see if this still happens for you?

@einsteinx2
Copy link
Owner

This is weird, it seems to happen sometimes, but then I restart wavebox and it's fine again. I'm going to go over my FSEvents code again with a fine toothed comb, but I'm not sure if it's an issue with the C# p/invoke or with the native code.

@benjmiller86
Copy link
Author

After pulling latest changes, still having troubles with multiple libraries

Same crash

https://gist.github.com/benjmiller86/50bad55ac5a57194a32a#file-nohup-out

@mdlayher
Copy link
Contributor

Do you have trailing slashes in your media folders in your ~/.wavebox/wavebox.conf? If so, that may be the problem. I fixed it a few days ago with #130. If you do have trailing slashes, try removing ~/.wavebox/wavebox.db, removing the slashes, and trying to run WaveBox again.

EDIT: I notice you tried both cases above, but give it another shot now after removing your database, and see what happens. I had a similar problem on Linux, and this fixed it.

@benjmiller86
Copy link
Author

@mdlayher That was it! Perhaps there should be a note in the config comment to nix the trailing slashes?

Thanks

@mdlayher
Copy link
Contributor

@benjmiller86 I put in a patch to fix this recently, and can confirm that it works both with and without the trailing slash on the latest git build, on Linux 64-bit. The next set of tarballs should have the patch for sure.

@benjmiller86
Copy link
Author

This is nuts...

Woke up, couldn't reopen WaveBox. Same error still persisting. I even tried dumping the build and started over.

Dumped the .db, adding/removing slashes, etc, this is so weird. Same error/abort when using multiple libraries

Tried pulling any updates. None available...

@benjmiller86 benjmiller86 reopened this Jul 24, 2013
@mdlayher
Copy link
Contributor

I'm still unable to replicate your issue on my setup, even after playing around a bit with media folders and such. Could you please delete Wavebox.Server/bin/Debug/wavebox_log.txt, run WaveBox, then post that log along with your ~/.wavebox/wavebox.conf?

The only thing I can figure is that your build is still somehow out of date, or that Ben's filesystem watching changes for OSX are introducing a new issue into the codebase.

@benjmiller86
Copy link
Author

Yeah still no luck. I have attached log and conf

Do you want to remote in?

http://pastie.org/8171126
http://pastie.org/8171131

@mdlayher
Copy link
Contributor

Yep, it's the native FSevents stuff on OSX. @einsteinx2 , this is all you.

@einsteinx2
Copy link
Owner

Ya @mdlayher I'll handle it, I need to modify my objc test app that uses the fsevents lib to test multiple paths, then have @benjmiller86 try that and see if it crashes. If it doesn't, then it's got to be something funky C# is doing when interoping.

@einsteinx2
Copy link
Owner

Interesting development on this. I can reproduce this if I watch 2 directories with FSEvents using the same dylib but with my test app, and then I start WaveBox. Or conversely, if I have WaveBox running and then start the test app. So perhaps there is something we need to handle regarding that.

@einsteinx2
Copy link
Owner

@benjmiller86 I found out how to get better crash logs. Can you open the Console app and look on the left for any logs that start with mono. You can right click them and click Reveal in Finder to show them. Just zip up all the mono ones. Then I can better debug it.

@benjmiller86
Copy link
Author

@einsteinx2
Copy link
Owner

Thanks, those are much more helpful. Ya it looks like the issue is always when actually setting the directories to be monitored, though your crash is slightly different than mine, but on the same line.

I'm going to rewrite it in Objective-C using an FSEvents wrapper so I can have cleaner, higher level code. No more pointer juggling. I'll do some testing on my side once I rewrite it then add it to the repo.

@ghost ghost assigned einsteinx2 Sep 18, 2013
@mdlayher
Copy link
Contributor

Assigning to Ben because he's handling FSEvents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants