-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename plugin to pytest-logging #19
Comments
#20 should prepare catchlog for this |
Let me know when you want to take care of this. I recently had 2 users trying to install pytest-logging which I directed to pytest-catchlog. |
Sure! |
How is the status of this? IIUC, once this is renamed to pytest-dev/pytest#2159 has brought me back to this issue. 😁 |
Just tell me when and I'll pull the plug on the old pytest-logging plugin. |
Gentle ping to know about the status. 😁 |
No idea, I tuned out of here. This is probably something @eisensheng would need to do, as he's the owner of the package on PyPI and the repo and all that. |
What if we do the renaming and the merge (#8) into pytest-dev in one go? Then we would no |
@Thisch why would doing both at the same time give us the right to do it without the author's knowledge? |
Hmm it's worrying that the last activity on GitHub by @eisensheng was in September 2016, according to his profile... It would be nice if he could give us a ping here. |
@Thisch oh just realized you meant merging with pytest-logging, and not merging it with the pytest-dev organization, sorry for the confusion com my part. I see your point now. |
I didn't know that there is a pytest-logging package on pypi (Now I understand what @s0undt3ch meant in #19 (comment)). I really meant merging pytest-catchlog into pytest-dev/pytest, as requested in #8. I would also prefer if @eisensheng gives us a +1, but what if he doesn't respond? |
Yeah we have to decide what to do, @eisensheng has been inactive from GitHub for a year now. |
@s0undt3ch are you still interested on the merge of pytest-catchlog + pytest-logging and the move to pytest-dev? And if so would you be the main maintainer over pytest-dev/pytest-logging? |
Yep, I haven't developed my plugin further just to get them both merged. As to taking principal role in managing the project, I also don't have much free time these days, ideally, someone with some more available time should take up that role. |
Also, if pytest is open to include this functionality into core of pytest, I'd vote for that. |
I volunteer to integrate this plugin into pytest-dev. |
@Thisch feel free to CC me on your PR or ping me if you need any help. Thanks for stepping up. |
You can already take a look at my feature branch here. Before I create a pull request on pytest-dev, I would first like to wait a bit until I get a few more comments from other developers. My feature branch does not yet include any code from pytest-logging. What exactly do you need from your plugin? |
@s0undt3ch have you tested my feature branch yet? If you are satisfied, I'll create a PR, provided that no one objects. |
Sorry @Thisch, I have not. I'm on vacations. I'll see if I can give it a spin on Monday morning. |
Never mind. I'll create a PR for pytest-dev/pytest tomorrow, if no one objects. |
Oops, disregard the above. Turns out, we only have push access, and can't manage the GitHub repository. |
Since the pytest-catchlog plugin was merged into the pytest core, this probably isn't applicable anymore. |
Rename the Plugin to pytest-logging.
The main argument against the rename was that a third name may further stir the confusion around the logging plugins for pytest.
This argument is somewhat obsolete now since a new plugin with the name pytest-logging actually appeared and further stirred the confusion around the logging plugins. So the plugin pytest-catchlog should be renamed to pytest-logging once the functionality of the current pytest-logging plugin has been merged into pytest-catchlog.
I still want a dream catcher for the logo of this plugin though!
The text was updated successfully, but these errors were encountered: