Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plugin to pytest-logging #19

Closed
eisensheng opened this issue Nov 11, 2015 · 24 comments
Closed

Rename plugin to pytest-logging #19

eisensheng opened this issue Nov 11, 2015 · 24 comments
Milestone

Comments

@eisensheng
Copy link
Owner

Rename the Plugin to pytest-logging.

The main argument against the rename was that a third name may further stir the confusion around the logging plugins for pytest.

This argument is somewhat obsolete now since a new plugin with the name pytest-logging actually appeared and further stirred the confusion around the logging plugins. So the plugin pytest-catchlog should be renamed to pytest-logging once the functionality of the current pytest-logging plugin has been merged into pytest-catchlog.

I still want a dream catcher for the logo of this plugin though!

@eisensheng eisensheng added this to the 2.0 milestone Nov 11, 2015
@s0undt3ch
Copy link
Contributor

#20 should prepare catchlog for this

@s0undt3ch
Copy link
Contributor

Let me know when you want to take care of this. I recently had 2 users trying to install pytest-logging which I directed to pytest-catchlog.

@abusalimov
Copy link
Collaborator

Sure!

@nicoddemus
Copy link
Contributor

How is the status of this? IIUC, once this is renamed to pytest-logging we would like move it to the pytest-dev organization, correct?

pytest-dev/pytest#2159 has brought me back to this issue. 😁

@s0undt3ch
Copy link
Contributor

Just tell me when and I'll pull the plug on the old pytest-logging plugin.

@nicoddemus
Copy link
Contributor

Gentle ping to know about the status. 😁

cc @The-Compiler

@The-Compiler
Copy link
Collaborator

No idea, I tuned out of here. This is probably something @eisensheng would need to do, as he's the owner of the package on PyPI and the repo and all that.

@twmr
Copy link

twmr commented Sep 13, 2017

What if we do the renaming and the merge (#8) into pytest-dev in one go? Then we would no
longer have to wait for the feedback from @eisensheng.

@nicoddemus
Copy link
Contributor

@Thisch why would doing both at the same time give us the right to do it without the author's knowledge?

@nicoddemus
Copy link
Contributor

Hmm it's worrying that the last activity on GitHub by @eisensheng was in September 2016, according to his profile... It would be nice if he could give us a ping here.

@nicoddemus
Copy link
Contributor

@Thisch oh just realized you meant merging with pytest-logging, and not merging it with the pytest-dev organization, sorry for the confusion com my part. I see your point now.

@twmr
Copy link

twmr commented Sep 13, 2017

I didn't know that there is a pytest-logging package on pypi (Now I understand what @s0undt3ch meant in #19 (comment)). I really meant merging pytest-catchlog into pytest-dev/pytest, as requested in #8. I would also prefer if @eisensheng gives us a +1, but what if he doesn't respond?

@nicoddemus
Copy link
Contributor

Yeah we have to decide what to do, @eisensheng has been inactive from GitHub for a year now. ☹️

@nicoddemus
Copy link
Contributor

nicoddemus commented Sep 13, 2017

@s0undt3ch are you still interested on the merge of pytest-catchlog + pytest-logging and the move to pytest-dev? And if so would you be the main maintainer over pytest-dev/pytest-logging?

@s0undt3ch
Copy link
Contributor

Yep, I haven't developed my plugin further just to get them both merged. As to taking principal role in managing the project, I also don't have much free time these days, ideally, someone with some more available time should take up that role.

@s0undt3ch
Copy link
Contributor

Also, if pytest is open to include this functionality into core of pytest, I'd vote for that.

@twmr
Copy link

twmr commented Sep 13, 2017

I volunteer to integrate this plugin into pytest-dev.

@s0undt3ch
Copy link
Contributor

@Thisch feel free to CC me on your PR or ping me if you need any help.
I'd like to take your code for a spin to see if what was included from pytest-logging is still working :)
But I'm sure you'll do awesome work!

Thanks for stepping up.

@twmr
Copy link

twmr commented Sep 13, 2017

You can already take a look at my feature branch here. Before I create a pull request on pytest-dev, I would first like to wait a bit until I get a few more comments from other developers. My feature branch does not yet include any code from pytest-logging. What exactly do you need from your plugin?

@twmr
Copy link

twmr commented Sep 15, 2017

@s0undt3ch have you tested my feature branch yet?

If you are satisfied, I'll create a PR, provided that no one objects.

@s0undt3ch
Copy link
Contributor

Sorry @Thisch, I have not. I'm on vacations. I'll see if I can give it a spin on Monday morning.

@twmr
Copy link

twmr commented Sep 20, 2017

Never mind. I'll create a PR for pytest-dev/pytest tomorrow, if no one objects.

@abusalimov
Copy link
Collaborator

abusalimov commented Sep 20, 2017

Just in case, @eisensheng has added me and @The-Compiler as the repository owner, so when the time comes IIUC we should be able to move the repository to the pytest-dev org so that all the issues and PR of this repository are retained. I'm not sure about PyPI and Travis accounts though.

Oops, disregard the above. Turns out, we only have push access, and can't manage the GitHub repository.

@The-Compiler
Copy link
Collaborator

The-Compiler commented Dec 5, 2017

Since the pytest-catchlog plugin was merged into the pytest core, this probably isn't applicable anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants