name conflict with the lsp package

[blackbird1128]

Describe the bug

A name conflict between the lsp package (lsp) and coq-lsp.lsp makes it impossible to use them both together due to a module name clash. Both libraries export a module named Lsp.

To Reproduce
In a Dune project, try linking lsp and coq-lsp.lsp

(executable
 (public_name foo)
 (name main)
 (libraries foo lsp coq-lsp.lsp))

Dune will indicate various errors when trying to use anything from Lsp

Expected behavior

As both libraries can be used together, renaming the coq-lsp.lsp module to something more precise would avoid the name conflict.

Desktop

• OS: Ubuntu
• coq-lsp version: 0.1.8
• VS Code version: not used here

Additional context

• see https://coq.zulipchat.com/#narrow/channel/329642-coq-lsp/topic/coq-lsp.20and.20ocaml for more details

[ejgallego]

Thanks for the report, will fix ASAP by renaming the module to Fleche_lsp.

We'd like to use upstream LSP libraries (cc: #2 ), however, we support some extensions, for example with Range-based offsets, which make us hard to use them for now.

But it is still in the roadmap to eventually remove our own Lsp implementation.