Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows Forms references from projects that don't need them. #59

Open
ekolis opened this issue Jan 4, 2021 · 0 comments
Open
Labels
idea Something that requires some thought and planning before it can be implemented. technical debt Code that could be improved to improve maintainability.
Milestone

Comments

@ekolis
Copy link
Owner

ekolis commented Jan 4, 2021

** Describe what needs to be improved. **

Even the Common project contains a reference to System.Windows.Forms because it contains save file dialogs of all things. These sorts of references should be moved into a WinForms specific project. And business logic should be moved out of the UI layers when appropriate, into Common or someplace like that.

Perhaps we could also reorganize the different projects into a smaller number; I'm not convinced that we need six of them!

** Describe how this change could impact the quality of the code. **

It would improve separation of concerns and make the code more understandable.

@ekolis ekolis added idea Something that requires some thought and planning before it can be implemented. technical debt Code that could be improved to improve maintainability. labels Jan 4, 2021
@ekolis ekolis added this to the 0.4.3 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Something that requires some thought and planning before it can be implemented. technical debt Code that could be improved to improve maintainability.
Projects
None yet
Development

No branches or pull requests

1 participant