Redux store does not get set initially when cache is primed

[RobertButera]

Hi,

I think there us an issue with redux-falcor. Essentially if you prime your falcor cache by doing something like this:

const falcor = new Model({
  cache: {
    person: {
      name: "rob"
    }
  }
});

And then setup redux-falcor as per README, then the redux store does not get set with this data.

After staring at your implementation for a while, I realised redux-falcor relies on the falcor onChange() method being invoked (to populate the redux store). This does not appear to get invoked as part of cache priming (or if it does, gets executed before redux-falcor monkey patches the handler)

I tested the theory by starting with an empty falcor cache and then setting the person key after 3 seconds (using setTimeout). Once I did it this way, the redux store got populated with my initial falcor dataset after the setTimeout executed.

Anyway, that aside, thanks for the library. I think redux-falcor does a really nice job of integrating falcor and redux.

[ekosz]

Hey @RobertButera,

I'm in crunch mode right now at work and I'm not quite sure when I'll get a chance to look into this. But once I get some time on my hands I will try and fix for sure.

In the meantime if anyone wants to take a crack at this, I'm happy to review any and all PRs.

[RobertButera]

Hey, thanks for getting back to me.

Will have a crack sometime this week if I get a chance.

Rob

[blackxored]

@RobertButera I was able to find an albeit cleaner workaround with setting the model as a proxied-to-cache data source. It does trigger there.

const model = /*... your old model data with only cache */

export default new falcor.model({ source: model.asDataSource() });

EDIT: typos 🎯

[pickhardt]

@blackxored I believe this would fix it. #26 ?