Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show Normally Hidden Components" hides normally hidden components instead #3

Open
Compsogbrickus opened this issue May 19, 2024 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@Compsogbrickus
Copy link

Mod version (NOT Minecraft version)

1.0.3

A description of the issue

The "Show Normally Hidden Components" option hides normally hidden components instead when enabled, and shows them when disabled.

Log or crash report

No response

@ekulxam
Copy link
Owner

ekulxam commented May 19, 2024

Hmm, I probably should have named that one better. Basically, since components like enchantments show themselves (most of the time), it won't show those components (because showing them twice would be redundant). However, enchantments have a showInTooltip feature, which can be turned off. If the showInTooltip feature is off, then the enchantment will not show itself in the tooltip, so Component View will add it at the bottom. Otherwise, it won't show.

I think it works as intended? Let me know if my explanation made sense, and if you have any suggestions for a rename, feel free to give me some ideas.

@ekulxam ekulxam self-assigned this May 19, 2024
@ekulxam ekulxam added the bug Something isn't working label May 19, 2024
@ekulxam ekulxam added help wanted Extra attention is needed and removed bug Something isn't working labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants