Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricbeat.reference.yml contradict the official documentation #33938

Closed
ker2x opened this issue Dec 5, 2022 · 4 comments · Fixed by #37430
Closed

metricbeat.reference.yml contradict the official documentation #33938

ker2x opened this issue Dec 5, 2022 · 4 comments · Fixed by #37430
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@ker2x
Copy link

ker2x commented Dec 5, 2022

In metricbeat.reference.yml, the documentations says :

# Disable the check for an existing lifecycle policy. The default is true. If
# you disable this check, set setup.ilm.overwrite: true so the lifecycle policy
# can be installed.
#setup.ilm.check_exists: true

It is misleading and imply that the ilm policy can be installed even if check_exist is false.
But this is not the case (tested on 8.4.2) and the official documentation agree.

A correct comment would be (shortened copy/paste from the official doc):

# Disable the check for an existing lifecycle policy. The default is true. 
# If you set this option to false, lifecycle policy will not be installed, 
# even if setup.ilm.overwrite is set to true.
#setup.ilm.check_exists: true

If setup.ilm.check_exists is set to false, the ILM policy is silently ignored.

I can create a pull request if you want.
Or a contributor can just modify the 4 line.
the PR process is needlessly complicated for such a non-functional (but important) modification.

hugs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2022
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2022
@botelastic
Copy link

botelastic bot commented Dec 12, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 12, 2023
@ker2x
Copy link
Author

ker2x commented Dec 12, 2023

i rechecked the official documentation and it still contradict the comment in the yml

@belimawr
Copy link
Contributor

@ker2x here is the PR: #37430

Thanks for the help!

@belimawr belimawr self-assigned this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants