Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set add_cloud_metadata/provider_aws_ec2.go/addTags's loglevel to info or debug #42182

Open
kimxogus opened this issue Dec 30, 2024 · 1 comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label

Comments

@kimxogus
Copy link

kimxogus commented Dec 30, 2024

Describe the enhancement:

Current implementation of addTags generates warning log when addTagsFromIMDSfails and then calls ec2.DescribeTags.
In k8s environment, I believe this is unnecessary warning log because many k8s provisioning tools doesn't support instance metadata tags option(refer to karpenter and kops links below). Also, as instance metadata tags is not enabled by default, many users will get warning logs which doesn't affect filebeat's behavior getting instance tags because there's fallback using ec2.DescribeTags.

Describe a specific use case for the enhancement or feature:

Make loglevel in getTagsFromIMDS info or debug

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 30, 2024
@botelastic
Copy link

botelastic bot commented Dec 30, 2024

This issue doesn't have a Team:<team> label.

@kimxogus kimxogus changed the title Set add_cloud_metadata/provider_aws_ec2/addTags's loglevel to info or debug Set add_cloud_metadata/provider_aws_ec2.go/addTags's loglevel to info or debug Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

No branches or pull requests

1 participant