Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: add metrics for number of events and pages published #42442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

x-pack/filebeat/input/httpjson: add metrics for number of events and pages published #42442

wants to merge 1 commit into from
+31 −12

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 28, 2025

Proposed commit message

This is intended to match the events and batches published by the CEL input, but there is no concept of batches in HTTPJSON, the nearest being paging.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-7.17 Automated backport to the 7.17 branch with mergify Team:Security-Service Integrations Security Service Integrations Team backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Jan 28, 2025
@efd6 efd6 self-assigned this Jan 28, 2025
@efd6 efd6 requested a review from a team as a code owner January 28, 2025 02:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 28, 2025
@efd6
x-pack/filebeat/input/httpjson: add metrics for number of events and …
1eae9ce 
…pages published

This is intended to match the events and batches published by the CEL
input, but there is no concept of batches in HTTPJSON, the nearest being
paging.
@efd6 efd6 marked this pull request as draft January 28, 2025 02:32
@efd6 efd6 marked this pull request as ready for review January 28, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efd6 efd6

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpjson: add event publishing metrics
2 participants
@efd6 @elasticmachine