Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dbadger-io dependency #42443

Open
dliappis opened this issue Jan 28, 2025 · 4 comments
Open

Drop dbadger-io dependency #42443

dliappis opened this issue Jan 28, 2025 · 4 comments
Assignees
Labels
libbeat :Processors Team:Service-Integrations Label for the Service Integrations team x-pack Issues and pull requests for X-Pack features.

Comments

@dliappis
Copy link
Contributor

dliappis commented Jan 28, 2025

dbadger is used as part of the add_cloudfoundry_metadata processor (dependency defined here and in go.mod).

As described in dgraph-io/badger#2155, Badger is currently utilizing the package go.opencensus.io, which has been archived since 2023 and is no longer recommended for use. Additionally, it cannot be downloaded without the Go proxy due to an expired certificate on their site. The dependency on go.opencensus.io results in build failures as seen e.g. in https://buildkite.com/elastic/beats-xpack-metricbeat/builds/10786#01948d0d-6915-43c7-b0f0-07ef954e2ee0/134-400

It could probably be replaced with something else, probably bbolt which is already used elsewhere in beats and is what otel’s file storage extension uses.

@dliappis dliappis added :Processors libbeat x-pack Issues and pull requests for X-Pack features. labels Jan 28, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2025
@dliappis
Copy link
Contributor Author

@jlind23 could you help assigning this the right Team: label?

@jlind23 jlind23 added the Team:Service-Integrations Label for the Service Integrations team label Jan 28, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2025
@jlind23
Copy link
Collaborator

jlind23 commented Jan 28, 2025

@lalit-satapathy adding this to your plate as your team owns everything cloudfoundry related.

@lalit-satapathy
Copy link
Contributor

@lalit-satapathy adding this to your plate as your team owns everything cloudfoundry related.

Adding to team backlog for next sprint. CC: @stefans-elastic

@stefans-elastic
Copy link
Contributor

@dliappis I've been working on this and noticed that not only badger depends on go.opencensus.io

Image

If i'm reading go mod graph correctly then getting rid of badger wouldn't be enough to get rid of go.opencensus.io.
That being said I think we still need to get rid of badger (like you said - in other places bbolt is used, so i don't think we need to use different packages for the same job, bbolt should be enough). What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat :Processors Team:Service-Integrations Label for the Service Integrations team x-pack Issues and pull requests for X-Pack features.
Projects
None yet
Development

No branches or pull requests

4 participants