You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
f"Skipping data for type {url_name} from {url}. Exception: {exception}."
)
break
It would be better for these to be re-raised if they can't be handled, and for callers to be able to determine how significant the error is. Otherwise, critical calls (like the first attempt to list all pages) could fail, leading to a mostly empty sync that thinks it's successful.
Acceptance Criteria
paginated_api_call catches some types of errors, and retries/handles the ones it can
if paginated_api_call cannot handle an error, it re-raises it
calling code of paginated_api_call handles errors as makes sense for the use case. We balance the need to "fail fast" with the need to not crash a large sync because of a small data issue.
The text was updated successfully, but these errors were encountered:
Part of #2393
Description
The confluence connector currently swallows errors during its
paginated_api_call()
function. See:connectors/connectors/sources/confluence.py
Lines 194 to 198 in 8c8d4a3
It would be better for these to be re-raised if they can't be handled, and for callers to be able to determine how significant the error is. Otherwise, critical calls (like the first attempt to list all pages) could fail, leading to a mostly empty sync that thinks it's successful.
Acceptance Criteria
paginated_api_call
catches some types of errors, and retries/handles the ones it canpaginated_api_call
cannot handle an error, it re-raises itpaginated_api_call
handles errors as makes sense for the use case. We balance the need to "fail fast" with the need to not crash a large sync because of a small data issue.The text was updated successfully, but these errors were encountered: