From 6b4f4ece402a68ceab9f5259e5fbb5dbe6c3df84 Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Thu, 26 Dec 2024 13:48:02 -0500 Subject: [PATCH 1/2] ESQL: Fix writing for LOOKUP status This fixes writing the `status` of the LOOKUP operator. It just wasn't registered. Closes #119086 --- muted-tests.yml | 2 -- .../java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index 008eb5ae47dfc..ad6eeba85cdb1 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -277,8 +277,6 @@ tests: issue: https://github.com/elastic/elasticsearch/issues/115727 - class: org.elasticsearch.xpack.security.authc.kerberos.KerberosAuthenticationIT issue: https://github.com/elastic/elasticsearch/issues/118414 -- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlClientYamlIT - issue: https://github.com/elastic/elasticsearch/issues/119086 - class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT method: test {yaml=reference/search/search-your-data/retrievers-examples/line_98} issue: https://github.com/elastic/elasticsearch/issues/119155 diff --git a/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java b/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java index 67948fe717f2f..b79dda900f39c 100644 --- a/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java +++ b/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java @@ -61,6 +61,7 @@ import org.elasticsearch.xpack.esql.action.RestEsqlGetAsyncResultAction; import org.elasticsearch.xpack.esql.action.RestEsqlQueryAction; import org.elasticsearch.xpack.esql.enrich.EnrichLookupOperator; +import org.elasticsearch.xpack.esql.enrich.LookupFromIndexOperator; import org.elasticsearch.xpack.esql.execution.PlanExecutor; import org.elasticsearch.xpack.esql.expression.ExpressionWritables; import org.elasticsearch.xpack.esql.plan.PlanWritables; @@ -192,6 +193,7 @@ public List getNamedWriteables() { entries.add(SingleValueQuery.ENTRY); entries.add(AsyncOperator.Status.ENTRY); entries.add(EnrichLookupOperator.Status.ENTRY); + entries.add(LookupFromIndexOperator.Status.ENTRY); entries.addAll(BlockWritables.getNamedWriteables()); entries.addAll(ExpressionWritables.getNamedWriteables()); From f4807f16970c2fe4c11f2552de253f66e2f45c09 Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Thu, 26 Dec 2024 14:42:12 -0500 Subject: [PATCH 2/2] Update docs/changelog/119296.yaml --- docs/changelog/119296.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 docs/changelog/119296.yaml diff --git a/docs/changelog/119296.yaml b/docs/changelog/119296.yaml new file mode 100644 index 0000000000000..f1a92cffb5131 --- /dev/null +++ b/docs/changelog/119296.yaml @@ -0,0 +1,6 @@ +pr: 119296 +summary: Fix writing for LOOKUP status +area: ES|QL +type: bug +issues: + - 119086