Replies: 7 comments 2 replies
-
Yes, thanks for calling this out. |
Beta Was this translation helpful? Give feedback.
-
Though I like the distinction of I'd probably side with having a consistent API and using EUI is probably just too abstracted from the DOM that knowing that specific property state is difficult to consider as a consumer. We also have some areas where it's difficult to impossible to match the DOM API because the component will render different possible DOM implementations or one prop has to be used on multiple DOM nodes. |
Beta Was this translation helpful? Give feedback.
-
As more of an end user, I knew about DOM property syncing, but most of the controls are so abstracted from true singular elements that the usefulness of that knowledge seems unhelpful given the frequent property mismatches. |
Beta Was this translation helpful? Give feedback.
-
I agree with both of these. Having a predictable API is the most important consideration here. I'm unsure at this point if it'd be better to have one massive PR and a single breaking change release, or work through components individually. We could pair this work with the eventual Emotion conversion work. |
Beta Was this translation helpful? Give feedback.
-
As someone using it, I'd probably like to "eat" the cost of the breaking change all at once rather than across multiple releases. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
@myasonik brought up another discussion point about where do we go from here outside of specifically boolean properties and matching to DOM API. Like what about all the |
Beta Was this translation helpful? Give feedback.
-
This is most pronounced in the search results with
isDisabled
https://github.com/elastic/eui/search?q=isDisabled%3A+boolean
versus
disabled
:https://github.com/elastic/eui/search?q=disabled%3A+boolean
But it exists for
isLoading
andloading
, and presumably a few others I less commonly use.This naturally represents a breaking change request, but the idea is straightforward: just pick one direction (
isX
orx
) and use that moving forward rather than one or the other.Beta Was this translation helpful? Give feedback.
All reactions