Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[logstash] StatefulSet pvc default labels #1655

Open
martinlillemets opened this issue May 12, 2022 · 3 comments · May be fixed by #1656
Open

[logstash] StatefulSet pvc default labels #1655

martinlillemets opened this issue May 12, 2022 · 3 comments · May be fixed by #1656

Comments

@martinlillemets
Copy link

martinlillemets commented May 12, 2022

Describe the feature:
Currently there is no way to add custom labels to pvc created by statefulsets for logstash helm chart

I propose functionality to modify helm templates in logstash to support adding custom labels to PVCs created by StatefulSet.
The functionality can be mostly copy-pasted from elasticsearch helm chat where this functionality is implemented already

Describe a specific use case for the feature:
In my organisation all K8s objects have custom labels on them which are used to control logging and alerting flows.
Simplest example is prom alerting rule for pvc to alert me when elastic pvc are about to run out of capacity (logstash, elasticsearch).

@martinlillemets martinlillemets changed the title Logstash and elasticsearch pvc labelling [logstash][elasticsearch] pvc labelling May 13, 2022
@martinlillemets martinlillemets changed the title [logstash][elasticsearch] pvc labelling [logstash] StatefulSet pvc default labels May 16, 2022
@botelastic
Copy link

botelastic bot commented Aug 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@martinlillemets
Copy link
Author

Still waiting for review

@botelastic botelastic bot removed the triage/stale label Aug 17, 2022
@botelastic
Copy link

botelastic bot commented Nov 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants