-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated data streams for 9.0 #11775
Comments
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
The release of these changes should coincide with the timing of the 9.0 Elastic stack release. We should prepare the changes before then so that they are ready, but we hold off on the merge until 9.0 ships. |
@jsoriano , what are the consequences of removing data streams in serverless/non-serverless? |
|
@jamiehynds Related to Jamf Protect - there are customers out there that are using the V1 feature still as they have not yet migrated. I would recommend that we keep the V1 (telemetry_legacy) in for a bit still. |
@andrewkroh what is the plan to apply these changes? Is it to remove the data stream and set
We have three ways to control availability of packages:
Serverless only uses spec version constraints, it ignores kibana version constraints. I guess that when we talk about removing data streams in 9.0, we refer to removing data streams in packages while we change their kibana version constraints to include Removing the data streams this way will make the data streams to silently disappear for users of serverless.
Workflow is "smooth" now. If a data stream is removed now, the user can complete the upgrade without seeing any warning, and the data stream is effectively removed from their config. This is probably fine for cases where the data stream is broken now, but it may be too smooth for the cases where the users are using the removed data stream and should start using a different one. Users won't receive any explicit notification about their configs being removed. Expand for details on current behaviorTried now to remove a policy template from the apache package, and the main problem may be that no warning is reported to users. In some cases this may be good, because it is mostly transparent, but if the removed data stream was working for them, it may result in missing data.During the upgrade, the only moment you can see that there is a breaking change, is if you click to see the changelog, it is shown like this: I marked the checkbox to upgrade policies, and then I clicked to upgrade, and the upgrade succeeded, without any warning. But the policy was not automatically upgraded. Not sure if there is something in Fleet checking that things were being removed. If then I go to upgrade the policy, I see that it is ready to upgrade, and everything is good, but the removed httpjson data stream doesn't appear there. If I save there, the data stream is effectively removed from the config, and the user doesn't receive any warning. We have some proposals to try to improve the experience on this case:
I think we should at least to warn users when upgrading to a version with breaking changes. As it is late to make changes in Fleet for 9.0, I see these options:
ccing @nimarezainia @kpollich about the feasibility of planning these changes in the Spec and Fleet. |
Sounds good, thanks for the context @txhaflaire. @chemamartinez @chemamartinez can you ensure that the Jamf Protect remains as-is, and we don't remove the v1 telemetry until further instruction from Jamf. |
@chemamartinez asked:
@jamiehynds said:
It makes sense to coordinate with Anomali to ensure we don't remove the legacy data stream while the Elastic Extension software is still being offered to users. In general the new data stream is better and easier to set up, so I look forward to removing the legacy one if Anomali gives the go-ahead. |
@jamiehynds , @andrewkroh , we've deprecated the o365audit input 11 months ago, if we decide to remove the deprecated o365 datastream, should we consider removing the input as well (it's the only integration that is being used)? |
@narph @jsoriano @jamiehynds @andrewkroh What would be the best strategy here to remove data streams from packages or apply any other breaking change? based on recent comments
The problem I see with forcing packages where we delete data streams to support only 9.0 or higher, is that we will force users with these integrations to update the entire stack when we add enhancements or fixes on top of it, or we will have to continually backport the fixes to be included in these integrations. Another option is to continue to support 8.x and 9.0 in these integrations despite introducing a breaking change, which would make the breaking change not aligned with the 9.0 release. |
Exactly, if the data streams are removed, and the new versions support 9.0 only, the change will be aligned with 9.0, but you will need to backport fixes. But even in this case, the data streams removal will affect serverless, where no version constraint applies (serverless is also "versionless" 🙂)
Not sure if we have telemetry about usage of data streams, but if we have, I think I would avoid removing any data stream that is being used and is known to work properly. We may affect users that may not know that they are affected till too late. So, for any deprecated data stream or package:
It looks to me that aligning the removal with 9.0 gives little benefits, taking into account that serverless exists, and that we would like to support a broad range of stack versions with the same packages. |
Regarding the integrations 'above the line', namely Carbon Black Cloud, Snyk, M365 Defender, F5 and Symantec EDR. I think we're fine to go proceed with removal as the API's have been deprecated by each vendor, or we have newer packages to move to (F5/Symantec). Silently removing it and adding the breaking change to the changelog may be the easiest approach. Can we leave the integrations below the line untouched - in most cases the API's are still valid and work, and not a strong case for deprecation. |
👋 @jamiehynds do we need to continue publishing docs pages for the deprecated integrations after the 9.0.0 release? Our current docs automation isn't set up to do this since we use cc @alaudazzi |
Hey @colleenmcginnis - we're fine to remove the docs, but just need to be careful to remove the right docs, as it could be easy to mix them up As an example, we remove these F5 docs but keep these F5 docs. |
Goal Statement
There are instances in Security Integrations where the third-party vendor has deprecated an API (some appear as a 'legacy'). These APIs are deprecated and not even accessible to customers.
These integrations are as follows:
Proposed Approach
The proposed approach would be to immediately ensure the configuration settings are marked as deprecated and then remove them entirely for 9.0.
Timeline
The proposed timeline is to remove these configurations for the 9.0 release of the Elastic stack.
Customer Impact
The deprecated APIs are no longer accessible to our customers.
This dashboard shows the customer using these integrations.
Integrations list
Collect Carbon Black Cloud logs via API using HTTPJSON [Legacy]
. It affects three data streams (alert
,asset_vulnerability_summary
, andaudit
).alert
data stream. It has been replaced byalert_v7
relying on CEL.Collect Carbon Black Cloud logs via API using CEL [Beta]
.alert
data stream.log
data stream:M365D Incidents via SIEM API (Deprecated)
.Collect data from Snyk API (Legacy)
)audit
andvulnerabilities
, that have been replaced byaudit_logs
andissues
.f5
package.Deprecated. Use the F5 BIG-IP package instead.
Deprecated. Use the Symantec Endpoint Security package instead.
Open to discussion
threatstream
data stream was marked as deprecated a few months ago: [ti_anomali] Support the ThreatStream API #11309The two data sources are roughly equivalent, although there are significant differences in the data format and some other details.
telephony
data stream, as we already havetelephony_v2
. Would it be a problem to renametelephony_v2
totelephony
at this point? It would imply renaming fields, dataset name and dashboards.telemetry_legacy
data stream? According to [Jamf Protect] - Adding support for new Telemetry Data Stream #10152, it says that the Telemetry feature will migrate over to a new data model but doesn't specify if the new changes are available yet.telemetry_legacy
data stream for now.Collect Office 365 audit logs - Deprecated. Please disable this and use the CEL input instead.
audit
data stream going to be deprecated after the planned changes?The text was updated successfully, but these errors were encountered: