Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited 'Filter' bar that only allows for deselection of enabled filters #128568

Closed
ifrimere opened this issue Mar 25, 2022 · 13 comments
Closed

Limited 'Filter' bar that only allows for deselection of enabled filters #128568

ifrimere opened this issue Mar 25, 2022 · 13 comments
Labels
enhancement New value added to drive a business result Feature:Search Querying infrastructure in Kibana Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ifrimere
Copy link

Feature Description

Provide an embed filter option that only allows for selected filters to be displayed and cleared AND will not display the '+Add filters' capability.

Feature Use Case

  • We use Kibana Dashboard embeds in our client facing portal
  • We want our clients to be able to interact with the visualizations and filter by selection of items BUT
  • We don't want our clients to have access to all the 'Add Filter' pulldown options
  • We want a new Embed/Filter option to enable for Embeds that only allows for 'de-selection' of filters

Reference images

image

image

@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 28, 2022
@stratoula stratoula added the enhancement New value added to drive a business result label Mar 28, 2022
@jloleysens
Copy link
Contributor

Hey @ifrimere ! Perhaps another way to solve for this UX is to provide toggle-able, non-editable filters. In that way the user can only remove or add the filters captured in the embed.

Would that also solve your use case?

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 4, 2022
@ifrimere
Copy link
Author

ifrimere commented Apr 4, 2022

@jloleysens - Curious what the UX/UI implementation would be for your suggestion, both for the 'admin' (defining the embed rules) and the customer consuming the Dashboards, but your idea sounds about right. Thanks.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula added Team:AppServicesSv and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 29, 2022
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppServicesSv labels Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@flash1293
Copy link
Contributor

Taking a step back, is this even something the filter bar should do or is it more of a use case for controls on a dashboard? https://www.elastic.co/guide/en/kibana/master/add-controls.html

@stratoula
Copy link
Contributor

Can you elaborate Joe? From my understanding the request is:

  • When I embed my dashboard I want to see the filter badges that are created when you click a viz but I dont want to see the add new filters

Right now in order to be able to see the filter basges you have to select the Filter bar option which comes with the add filter button. I think they want to distinguish these two.

@flash1293
Copy link
Contributor

Good point, missed the part about retaining the filter-by-click logic. Makes sense under this consideration.

@ThomThomson
Copy link
Contributor

This also dips a little bit into the Controls X Unified search initiative. Right now the Controls are very non-integrated with all of the systems of Kibana, especially drilldowns and UI actions. Keeping Controls and unified search as two competing systems means that we'd have to provide a plethora of various patching behaviours and settings to integrate Controls with the rest of Kibana.

@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@Sujith1930
Copy link

Hi Team,
Is this issue still opened or it's fixed?
Since I am facing the same issue

@ThomThomson ThomThomson added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

ThomThomson commented Nov 2, 2023

@Sujith1930 - this issue is not quite fixed yet.

That said. I'm closing this in favour of #170448 as we could fulfill this request by allowing chart brushing to add controls selections instead. Then these selections would be clearable, and the unified search bar could remain hidden. You can follow along for updates on that issue instead.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Search Querying infrastructure in Kibana Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

10 participants