Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs Create Dashboard][KEYBOARD]: Focus must be set on the EuiScreenReaderOnly component that comes first in DOM on initial render #195027

Open
4 tasks
1Copenut opened this issue May 9, 2024 · 4 comments
Labels
defect-level-2 Serious UX disruption with workaround impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A

Comments

@1Copenut
Copy link
Contributor

1Copenut commented May 9, 2024

Point of contact

@petrklapka

Description

The Obs Create Dashboard has a screen reader only H1 that is taking keyboard focus on first render. This is an older pattern that has been updated with an EuiScreenReaderOnly that is the first item in the DOM and should receive focus on render. This makes for a more consistent UX for keyboard users and announces the page consistently for screen reader users while retaining teh H1 as "the big idea". Screenshot attached below.

Steps to recreate

  1. Open the Obs Serverless Dashboard view
  2. Start the screen reader of your choice
  3. Tab and click the Create dashboard button
  4. Verify you hear "Dashboards - Editing New Dashboard. Heading level one." This is the SR-only H1 taking focus.
  5. Press Tab and verify you never see the "Skip to main content" link

Environment

  • MacOS Ventura
  • Safari latest
  • VoiceOver

Screenshots or Trace Logs

Screenshot 2024-05-09 at 4 28 20 PM

Proposed solution

Focus should be consistent with all other views, going to the first EuiScreenReaderOnly component in the DOM. The H1 can stay in the DOM and should for screen readers, even if it's visually hidden.

Acceptance criteria

  • Correct focus order is honored in the Create Dashboard view
  • Pressing Tab once highlights the skip to content link on first render
  • The H1 is still available for screen reader users
  • No axe-core errors are thrown with code change

WCAG or Vendor Guidance (optional)

@1Copenut 1Copenut added WCAG A defect-level-2 Serious UX disruption with workaround labels May 9, 2024
@1Copenut 1Copenut transferred this issue from another repository Jul 25, 2024
@alexwizp alexwizp transferred this issue from another repository Oct 4, 2024
@alexwizp alexwizp added Team:obs-ux-management Observability Management User Experience Team Project:Accessibility labels Oct 4, 2024
@alexwizp alexwizp transferred this issue from elastic/transfer-issues Oct 4, 2024
@smith smith added the obs-accessibilty A11Y issues in the Obs. solution. label Oct 18, 2024
@jasonrhodes jasonrhodes added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jasonrhodes jasonrhodes removed the Team:obs-ux-management Observability Management User Experience Team label Nov 22, 2024
@Heenawter Heenawter added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Dec 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Heenawter
Copy link
Contributor

We're confused on the ownership of this one @elastic/appex-sharedux - do you know if this header belongs to the Serverless navigation or the Dashboard plugin? 🙇

@petrklapka petrklapka removed the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Dec 9, 2024
@petrklapka
Copy link
Member

Removing from our project, this is part of Dashboard app.

@ThomThomson ThomThomson added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-2 Serious UX disruption with workaround impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A
Projects
None yet
Development

No branches or pull requests

8 participants