Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·ts - security app users should show the default roles #200666

Closed
kibanamachine opened this issue Nov 19, 2024 · 33 comments · Fixed by #200679
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·ts - security app users should show the default roles #200666

kibanamachine opened this issue Nov 19, 2024 · 33 comments · Fixed by #200679
Assignees
@azasypkin
Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 19, 2024 •
edited
Loading

A test failed on a tracked branch

TypeError: Cannot read properties of undefined (reading 'reserved')
    at Context.<anonymous> (users.ts:114:29)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-elasticsearch-snapshot-verify - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 19, 2024
@kibanamachine kibanamachine added failed-es-promotion Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Nov 19, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-snapshot-verify - main

@elena-shostak elena-shostak mentioned this issue Nov 19, 2024
Merged
2 tasks
@kibanamachine kibanamachine reopened this Dec 17, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@azasypkin azasypkin self-assigned this Dec 17, 2024
@azasypkin
Copy link
Member

azasypkin commented Dec 17, 2024 •
edited
Loading

2024-12-17 07:07:56 CEST └-> "before each" hook: global before each for "should show the default roles"
2024-12-17 07:08:05 CEST └- ✖ fail: security app users should show the default roles
2024-12-17 07:08:05 CEST │ TypeError: Cannot read properties of undefined (reading 'reserved')
2024-12-17 07:08:05 CEST │ at Context. (users.ts:114:29)
2024-12-17 07:08:05 CEST │ at processTicksAndRejections (node:internal/process/task_queues:95:5)
2024-12-17 07:08:05 CEST │ at Object.apply (wrap_function.js:74:16)

It seems to point that beats_admin reserved user is no longer present, I'll figure this out.

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@azasypkin
Copy link
Member

azasypkin commented Dec 27, 2024 •
edited
Loading

@elastic/kibana-qa We have a few functional tests that need to make slightly different assertions based on the ES version Kibana is connected to, as some built-in roles that exist in 8.x are no longer present in 9.0. I’ve noticed a few places in our tests where we do something like this:

      log.debug(process.env.ORIGINAL_VERSION!);
      if (semver.lt(process.env.ORIGINAL_VERSION!, '7.6.0-SNAPSHOT')) {
        log.debug('Skipping! These tests are valid only for 7.6+ versions');
        this.skip();
      }

Is it still a recommended pattern to handle such cases in compatibility tests? If so, is it safe enough to rely on ORIGINAL_VERSION or is there some dedicated test service that can return ES version? E.g.,

      if (semver.lt(process.env.ORIGINAL_VERSION!, '9.0.0-SNAPSHOT')) {
        expect(roles.apm_user.reserved).to.be(true);
        expect(roles.apm_user.deprecated).to.be(true);
      } else {
        log.debug('The `apm_user` role no longer exists in 9.0.0+.');
      }

@azasypkin azasypkin mentioned this issue Dec 27, 2024
Merged
@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

azasypkin added a commit that referenced this issue Dec 30, 2024
@azasypkin
fix(tests): adapt tests using apm_user to ensure they can run again…
c347d12 
…st Elasticsearch 9.0.0 (#205213)

## Summary

Adapt tests using `apm_user` to ensure they can run against
Elasticsearch 9.0.0 either by checking ES version or switching to other
roles when possible.

Closes: #200666
Closes: #200667
@azasypkin
Copy link
Member

Should be fixed in #205213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azasypkin azasypkin

Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FTR] Cleaned up check for removed apm_user role elena-shostak/kibana
3 participants
@azasypkin @elasticmachine @kibanamachine