Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally add agentless index permissions #203810

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

orestisfl
Copy link

@orestisfl orestisfl commented Dec 11, 2024

Summary

Adds necessary permissions to write to the agentless-* index. See:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@orestisfl orestisfl force-pushed the agentless-storage-permissions branch from 72913fb to fa79140 Compare December 11, 2024 14:43
@orestisfl orestisfl marked this pull request as ready for review December 16, 2024 10:14
@orestisfl orestisfl requested a review from a team as a code owner December 16, 2024 10:14
@orestisfl orestisfl force-pushed the agentless-storage-permissions branch from b03c206 to 82cb077 Compare December 23, 2024 12:10
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 23, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 82cb077
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203810-82cb07732b6a

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @orestisfl

@orestisfl orestisfl changed the title WIP: conditionally add agentless index permissions Conditionally add agentless index permissions Dec 24, 2024
@orestisfl orestisfl added v9.0.0 Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Dec 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@orestisfl orestisfl requested review from a team and seanrathier December 24, 2024 15:08
Copy link
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why we need to do this. I tried getting the gist from reading the parent issues but still don't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:build-serverless-image Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants