-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally add agentless index permissions #203810
Open
orestisfl
wants to merge
6
commits into
elastic:main
Choose a base branch
from
orestisfl:agentless-storage-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orestisfl
force-pushed
the
agentless-storage-permissions
branch
from
December 11, 2024 14:43
72913fb
to
fa79140
Compare
This reverts commit 3c367e0.
orestisfl
force-pushed
the
agentless-storage-permissions
branch
from
December 23, 2024 12:10
b03c206
to
82cb077
Compare
botelastic
bot
added
the
Team:Fleet
Team label for Observability Data Collection Fleet team
label
Dec 23, 2024
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @orestisfl |
orestisfl
changed the title
WIP: conditionally add agentless index permissions
Conditionally add agentless index permissions
Dec 24, 2024
orestisfl
added
v9.0.0
Team:Cloud Security
Cloud Security team related
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
v8.18.0
labels
Dec 24, 2024
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
seanrathier
reviewed
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand why we need to do this. I tried getting the gist from reading the parent issues but still don't understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
ci:build-serverless-image
Team:Cloud Security
Cloud Security team related
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds necessary permissions to write to the
agentless-*
index. See:Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.