[User] Prevent disabled input change by password manager #204269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
release_note:fix
backport:prev-minor
nickofthyme
changed the title
jeramysoucy
reviewed
Dec 13, 2024
x-pack/plugins/security/public/authentication/login/components/login_form/login_form.tsx
Outdated
Show resolved
Hide resolved
|
@elastic/kibana-security could I get another look at this? Thanks! |
jeramysoucy
previously approved these changes
Jan 8, 2025
jeramysoucy
dismissed
their stale review
Nit: would it be possible to augment the unit tests to validate this change?
|
Good point @jeramysoucy. Added test in f2ab08d. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
jeramysoucy
approved these changes
Jan 9, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 9, 2025
) Prevents username input from being edited by password manager extensions when `disabled` (cherry picked from commit d96168c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2025
…) (#206152) # Backport This will backport the following commits from `main` to `8.x`: - [[User] Prevent disabled input change by password manager (#204269)](#204269) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-09T22:48:03Z","message":"[User] Prevent disabled input change by password manager (#204269)\n\nPrevents username input from being edited by password manager extensions when `disabled`","sha":"d96168c64f88547aa2f8aa1f991fbfda899218a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor"],"title":"[User] Prevent disabled input change by password manager","number":204269,"url":"https://github.com/elastic/kibana/pull/204269","mergeCommit":{"message":"[User] Prevent disabled input change by password manager (#204269)\n\nPrevents username input from being edited by password manager extensions when `disabled`","sha":"d96168c64f88547aa2f8aa1f991fbfda899218a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204269","number":204269,"mergeCommit":{"message":"[User] Prevent disabled input change by password manager (#204269)\n\nPrevents username input from being edited by password manager extensions when `disabled`","sha":"d96168c64f88547aa2f8aa1f991fbfda899218a0"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents username input from being edited by password manager extensions when
disabled.fixes #204268
Checklist