Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Lens] Panel cannot reset changes after user clicks on switch to view mode on upgraded dashboard #204499

Open
bhavyarm opened this issue Dec 16, 2024 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Dec 16, 2024

Kibana version: 8.18.0 snapshot

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Panel reset doesn't happen on a panel which was switched to lens from legacy visualization on upgraded dashboard.

Steps to reproduce:
1.Open upgraded dashboard (am attaching the saved object)
2. Click on edit and then click on convert to lens on shakespeare pie_chart ->navigate to lens and click on replace in dashboard
3. Once on dashboard, click on switch to view mode
4. Kibana displays reset changes warning and upon confirmation displays "Unable to reset panel changes"
5. If you hit refresh the convert to lens changes are gone and old legacy viz gets displayed.

Screenshots (if relevant):

Image

shakespeare_dashboard.ndjson.zip

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 16, 2024
@dej611
Copy link
Contributor

dej611 commented Dec 17, 2024

Can it be related to @nreese recent #203158 ?

@nreese
Copy link
Contributor

nreese commented Dec 17, 2024

Can it be related to @nreese recent #203158 ?

I don't think so. The issue is tagged as 8.8.0 version which pre-dates the embeddable refactor. Although the toast message is from the PR so maybe the kibana version is incorrect.

@bhavyarm this is for 8.8.0 kibana version, right?

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Dec 17, 2024

@nreese

@bhavyarm this is for 8.8.0 kibana version, right?

Yes. Thanks!

@bhavyarm
Copy link
Contributor Author

@nreese @dej611 super sorry. My eyes didn't see 1 next to 8 when I logged and then I confirmed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants