Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[One Discover] Display stacktrace in the logs overview tab #204521

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Dec 17, 2024

📓 Summary

Adds a new section to the overview tab in the log details flyout in Discover to display stacktrace information for logs and exceptions.

Related to #190460

APM - Log stacktrace (library frames)

image

APM - Exception (with cause)

image

APM - Exception (simple stacktrace)

image

Apache Tomcat Integration (Catalina) - Stacktrace

image

📝 Notes for reviewers

  • Mark @kbn/apm-types as platform / shared as it's going to be used by the unified_doc_viewer
  • Move the code used to render stacktraces in APM into a new @kbn/event-stacktrace package as it will be reused in the unified_doc_viewer
  • Move the code used to render metadata table in APM into a new @kbn/key-value-metadata-table package

🧪 Testing instructions

  1. Run the simple_logs Synthtrace scenario: node scripts/synthtrace.js simple_logs --local
  2. Ingest some logs with stacktraces (gist). Please note that these are test data and some fields that are not used by stacktraces might not be consistent
  3. View relevant logs for the synth-node-0 service in Discover (Jan 1, 2024 - Jan 31, 2024)

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@gbamparop gbamparop added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 17, 2024
@gbamparop
Copy link
Contributor Author

/ci

@gbamparop gbamparop force-pushed the discover-logs-stacktrace branch from e11d28d to b41227d Compare December 17, 2024 08:57
@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/oblt-deploy

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop gbamparop changed the title Discover logs stacktrace [One Discover] Display stacktrace in the logs overview tab Dec 31, 2024
@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants