[ES body removal] @elastic/kibana-core
#204851
Open
+473
−535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
afharo
commented
Dec 20, 2024
Comment on lines
+10
to
+13
| import * as estypes from '@elastic/elasticsearch/lib/api/types'; | ||
| // TODO: Remove when all usages have been migrated to non-body | ||
| import { SearchRequest as SearchRequestWithBodyKey } from '@elastic/elasticsearch/lib/api/typesWithBodyKey'; | ||
| import type { Field, QueryDslFieldAndFormat } from '@elastic/elasticsearch/lib/api/types'; |
There was a problem hiding this comment.
making no-body the default, and flagging the intention to remove the WithBody one when all other PRs are merged.
|
Pinging @elastic/kibana-core (Team:Core) |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
⏳ Build in-progress
History
cc @afharo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to remove the deprecated
bodyin the ES client.There are some workarounds to be able to merge. The following PRs will address the removal of other teams' code:
bodyremoval]@elastic/ml-ui#204872bodyremoval]@elastic/obs-ux-management-team#204877bodyremoval]@elastic/obs-ux-logs-team#204863bodyremoval]@elastic/obs-ux-infra_services-team#204864