Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automatic Import] validate integration and datastream names in UI Form #204935

Closed
haetamoudi opened this issue Dec 19, 2024 · 1 comment · Fixed by #204943
Closed

[Automatic Import] validate integration and datastream names in UI Form #204935

haetamoudi opened this issue Dec 19, 2024 · 1 comment · Fixed by #204943
Assignees
@bhapas
Labels
bug Fixes for quality problems that affect the customer experience Feature:AutomaticImport Team:Security-Scalability Team label for Security Integrations Scalability Team

Comments

@haetamoudi
Copy link
Contributor

Right now the validation error will appear only when trying to deploy the newly created integration.
If the name is not valid, there is no way to update it and the user has to re-create the integration from scratch.

Image

We should validate the names early on, on the UI form.
@haetamoudi haetamoudi added the bug Fixes for quality problems that affect the customer experience label Dec 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 19, 2024
@haetamoudi haetamoudi added Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 19, 2024
@bhapas bhapas mentioned this issue Dec 19, 2024
Merged
2 tasks
@bhapas bhapas self-assigned this Dec 19, 2024
@bhapas bhapas closed this as completed in b746c39 Dec 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2024
@bhapas
[Automatic Import] Fix UI validation for Integration and Datastream n…
ac1cf60 
…ame (elastic#204943)

## Release Note

Fixes Integration and Datastream name validation

## Summary

elastic#204409 implemented backend
validation for integration and datastream names and this PR fixes
allowing numbers on backend

<img width="858" alt="image"
src="https://github.com/user-attachments/assets/8d61305a-eeb8-41d7-8fa0-f0b466fa7528"
/>

Closes elastic#204935

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit b746c39)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2024
@bhapas
[Automatic Import] Fix UI validation for Integration and Datastream n…
6bd32e9 
…ame (elastic#204943)

## Release Note

Fixes Integration and Datastream name validation

## Summary

elastic#204409 implemented backend
validation for integration and datastream names and this PR fixes
allowing numbers on backend

<img width="858" alt="image"
src="https://github.com/user-attachments/assets/8d61305a-eeb8-41d7-8fa0-f0b466fa7528"
/>

Closes elastic#204935

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit b746c39)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2024
@bhapas
[Automatic Import] Fix UI validation for Integration and Datastream n…
3a72d96 
…ame (elastic#204943)

## Release Note

Fixes Integration and Datastream name validation

## Summary

elastic#204409 implemented backend
validation for integration and datastream names and this PR fixes
allowing numbers on backend

<img width="858" alt="image"
src="https://github.com/user-attachments/assets/8d61305a-eeb8-41d7-8fa0-f0b466fa7528"
/>

Closes elastic#204935

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit b746c39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhapas bhapas

Labels
bug Fixes for quality problems that affect the customer experience Feature:AutomaticImport Team:Security-Scalability Team label for Security Integrations Scalability Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Automatic Import] Fix UI validation for Integration and Datastream name bhapas/kibana
3 participants
@elasticmachine @bhapas @haetamoudi