Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] add an accessible label to range slider #205308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Lens] add an accessible label to range slider #205308

wants to merge 2 commits into from
+31 −5

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Dec 31, 2024 •
edited
Loading

Summary

Fixes #182765 (with the solution suggested by @1Copenut)

@mbondyra mbondyra added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 31, 2024
@mbondyra mbondyra requested a review from a team as a code owner December 31, 2024 10:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra force-pushed the lens/accessibility-issue branch from 405351d to 3719f9f Compare December 31, 2024 10:50
@elastic elastic deleted a comment from elasticmachine Dec 31, 2024
@mbondyra mbondyra force-pushed the lens/accessibility-issue branch from 3719f9f to 0d15a16 Compare December 31, 2024 10:59
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts ES|QL mode should send no more than 2 search requests (documents + chart) on page load
  • [job] [logs] FTR Configs #79 / Serverless Common UI - Management Index Management Index Templates Create index template can create an index template with logsdb index mode

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +686.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard create visualization][SCREEN READER]: Range slider needs an accessible label for best usability
3 participants
@mbondyra @elasticmachine @kibanamachine