Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced #205544

Closed
bhavyarm opened this issue Jan 3, 2025 · 2 comments · Fixed by #205604
Assignees
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Jan 3, 2025

Description
When user tabs over sync alert status with case status toggle button under case settings on create case page, screenreader announces On, On switch without giving any context.

Preconditions
Security solution -> on cases page -> create case

Steps to reproduce

  1. Open cases and click on create case
  2. Tab through the page and run voiceover on it
  3. Notice that voice over on sync alert status with case status toggle button says On, On switch without any context
Image

Kibana Version: 8.17.0

OS: OX X

Browser: Chrome latest

WCAG or Vendor Guidance (optional)

Guidelines:
Understanding SC 4.1.2: Name, Role, Value (Level A)(https://www.w3.org/WAI/WCAG22/Understanding/name-role-value.html)

Related to: https://github.com/elastic/kibana-team/issues/1280

@bhavyarm bhavyarm added defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp self-assigned this Jan 6, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 6, 2025
…n under case settings on create case page is incorrectly announced

Closes: elastic#205544
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 7, 2025
…n under case settings on create case page is incorrectly announced

Closes: elastic#205544
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 8, 2025
…n under case settings on create case page is incorrectly announced (elastic#205604)

Closes: elastic#205544

## Description
When user tabs over sync alert status with case status toggle button
under case settings on create case page, screenreader announces On, On
switch without giving any context.

## Preconditions
Security solution -> on cases page -> create case

## Changes made:
1. added context for **EuiSwitch** by passing `aria-labelledby`
attribute

## Screen

![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)

(cherry picked from commit efe44b2)
kibanamachine added a commit that referenced this issue Jan 8, 2025
… button under case settings on create case page is incorrectly announced (#205604) (#205938)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Cases] Sync alert status with case status toggle
button under case settings on create case page is incorrectly announced
(#205604)](#205604)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:57:41Z","message":"fix:
[Security:Cases] Sync alert status with case status toggle button under
case settings on create case page is incorrectly announced
(#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs
over sync alert status with case status toggle button\r\nunder case
settings on create case page, screenreader announces On, On\r\nswitch
without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution
-> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added
context for **EuiSwitch** by passing
`aria-labelledby`\r\nattribute\r\n\r\n##
Screen\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix:
[Security:Cases] Sync alert status with case status toggle button under
case settings on create case page is incorrectly
announced","number":205604,"url":"https://github.com/elastic/kibana/pull/205604","mergeCommit":{"message":"fix:
[Security:Cases] Sync alert status with case status toggle button under
case settings on create case page is incorrectly announced
(#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs
over sync alert status with case status toggle button\r\nunder case
settings on create case page, screenreader announces On, On\r\nswitch
without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution
-> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added
context for **EuiSwitch** by passing
`aria-labelledby`\r\nattribute\r\n\r\n##
Screen\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205604","number":205604,"mergeCommit":{"message":"fix:
[Security:Cases] Sync alert status with case status toggle button under
case settings on create case page is incorrectly announced
(#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs
over sync alert status with case status toggle button\r\nunder case
settings on create case page, screenreader announces On, On\r\nswitch
without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution
-> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added
context for **EuiSwitch** by passing
`aria-labelledby`\r\nattribute\r\n\r\n##
Screen\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
…n under case settings on create case page is incorrectly announced (elastic#205604)

Closes: elastic#205544

## Description
When user tabs over sync alert status with case status toggle button
under case settings on create case page, screenreader announces On, On
switch without giving any context.

## Preconditions
Security solution -> on cases page -> create case

## Changes made: 
1. added context for **EuiSwitch** by passing `aria-labelledby`
attribute

## Screen


![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
3 participants