Update semantic_text query to use highlighting option #205795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikatsarkar056
force-pushed
the
playground_semantic_query
branch
from
cda8a3d to
368a0c0
Compare
saikatsarkar056
added
v8.18.0
Team:EnterpriseSearch
backport:prev-minor
saikatsarkar056
force-pushed
the
playground_semantic_query
branch
2 times, most recently
from
6dae019 to
1f132d5
Compare
joemcelroy
reviewed
Jan 8, 2025
x-pack/solutions/search/plugins/search_playground/public/utils/create_query.ts
Outdated
Show resolved
Hide resolved
|
This looks good so far! Theres likely going to be a number of units failing for this so need to run the test suite for this and fix the snapshots. |
joemcelroy
reviewed
Jan 8, 2025
x-pack/solutions/search/plugins/search_playground/public/utils/create_query.ts
Outdated
Show resolved
Hide resolved
saikatsarkar056
force-pushed
the
playground_semantic_query
branch
5 times, most recently
from
acb6955 to
bc2976c
Compare
saikatsarkar056
force-pushed
the
playground_semantic_query
branch
from
bc2976c to
2000496
Compare
saikatsarkar056
force-pushed
the
playground_semantic_query
branch
from
2000496 to
cf0334d
Compare
joemcelroy
reviewed
Jan 13, 2025
x-pack/solutions/search/plugins/search_playground/server/utils/get_value_for_selected_field.ts
Outdated
Show resolved
Hide resolved
joemcelroy
approved these changes
Jan 17, 2025
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 17, 2025
This PR addresses [this issue](elastic/search-team#8928) by replacing the current semantic_text implementation, which uses inner_hit, with semantic_text highlighting. https://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a --------- Co-authored-by: Joseph McElroy <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 575d57e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 17, 2025
…#207125) # Backport This will backport the following commits from `main` to `8.x`: - [Update semantic_text query to use highlighting option (#205795)](#205795) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saikat Sarkar","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-17T18:42:15Z","message":"Update semantic_text query to use highlighting option (#205795)\n\nThis PR addresses [this\r\nissue](elastic/search-team#8928) by replacing\r\nthe current semantic_text implementation, which uses inner_hit, with\r\nsemantic_text highlighting.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a\r\n\r\n---------\r\n\r\nCo-authored-by: Joseph McElroy <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"575d57e8fa7c75e1cf5549c839acb5a7d901611a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:EnterpriseSearch","backport:prev-minor","v8.18.0"],"title":"Update semantic_text query to use highlighting option","number":205795,"url":"https://github.com/elastic/kibana/pull/205795","mergeCommit":{"message":"Update semantic_text query to use highlighting option (#205795)\n\nThis PR addresses [this\r\nissue](elastic/search-team#8928) by replacing\r\nthe current semantic_text implementation, which uses inner_hit, with\r\nsemantic_text highlighting.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a\r\n\r\n---------\r\n\r\nCo-authored-by: Joseph McElroy <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"575d57e8fa7c75e1cf5549c839acb5a7d901611a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205795","number":205795,"mergeCommit":{"message":"Update semantic_text query to use highlighting option (#205795)\n\nThis PR addresses [this\r\nissue](elastic/search-team#8928) by replacing\r\nthe current semantic_text implementation, which uses inner_hit, with\r\nsemantic_text highlighting.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a\r\n\r\n---------\r\n\r\nCo-authored-by: Joseph McElroy <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"575d57e8fa7c75e1cf5549c839acb5a7d901611a"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saikat Sarkar <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
This PR addresses [this issue](elastic/search-team#8928) by replacing the current semantic_text implementation, which uses inner_hit, with semantic_text highlighting. https://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a --------- Co-authored-by: Joseph McElroy <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
This PR addresses [this issue](elastic/search-team#8928) by replacing the current semantic_text implementation, which uses inner_hit, with semantic_text highlighting. https://github.com/user-attachments/assets/bac8abf7-ec50-4463-b0ad-d3152872253a --------- Co-authored-by: Joseph McElroy <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue by replacing the current semantic_text implementation, which uses inner_hit, with semantic_text highlighting.
Screen.Recording.2025-01-10.at.1.35.06.PM.mov