[Obs AI Assistant] Fix knowledge base install status #205970
Assignees
Labels
Team:Obs AI Assistant
Observability AI Assistant
Comments
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
The I suggest leaving the Like you say, the UI will then use the |
|
To add to the description details, for whatever reason we only polled |
This was referenced Jan 9, 2025
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 15, 2025
) Resolves elastic#205970 Updates logic to account for knowledge base `/setup` no longer polling for model readiness before returning. - Currently we only poll `/status` if user manually installs the knowledge base. In cases where we auto installed, such as after successfully setting up a connector, we depended on `/setup` to poll internally. Since the latter was removed, we need to always poll `/status`, otherwise user could potentially be in the state where `setup` has finished (considered installed) but `status` still reports not ready and we show the install message again (see screenshots in elastic#205970) - Currently if an install is in progress and user closes the flyout, the progress state is lost. These changes should continue to reflect the installation progress in the UI. - Renames variables and adds comments for easier readability - adds unit test to component that handles the install UI state, `WelcomeMessageKnowledgeBase` --------- Co-authored-by: Søren Louv-Jansen <[email protected]> (cherry picked from commit 06526fe)
kibanamachine
added a commit
that referenced
this issue
Jan 15, 2025
…) (#206777) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] fix knowledge base installation state (#206130)](#206130) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sandra G","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T14:38:07Z","message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","ci:cloud-deploy","Team:Obs AI Assistant","ci:project-deploy-elasticsearch","ci:project-deploy-observability","backport:version","v8.18.0","v8.17.1"],"title":"[Obs AI Assistant] fix knowledge base installation state","number":206130,"url":"https://github.com/elastic/kibana/pull/206130","mergeCommit":{"message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206130","number":206130,"mergeCommit":{"message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sandra G <[email protected]>
neptunian
added a commit
to neptunian/kibana
that referenced
this issue
Jan 15, 2025
) Resolves elastic#205970 Updates logic to account for knowledge base `/setup` no longer polling for model readiness before returning. - Currently we only poll `/status` if user manually installs the knowledge base. In cases where we auto installed, such as after successfully setting up a connector, we depended on `/setup` to poll internally. Since the latter was removed, we need to always poll `/status`, otherwise user could potentially be in the state where `setup` has finished (considered installed) but `status` still reports not ready and we show the install message again (see screenshots in elastic#205970) - Currently if an install is in progress and user closes the flyout, the progress state is lost. These changes should continue to reflect the installation progress in the UI. - Renames variables and adds comments for easier readability - adds unit test to component that handles the install UI state, `WelcomeMessageKnowledgeBase` --------- Co-authored-by: Søren Louv-Jansen <[email protected]> (cherry picked from commit 06526fe) # Conflicts: # x-pack/packages/kbn-ai-assistant/src/chat/welcome_message_knowledge_base.test.tsx # x-pack/plugins/observability_solution/observability_ai_assistant/server/routes/knowledge_base/route.ts
neptunian
added a commit
that referenced
this issue
Jan 15, 2025
) (#206837) # Backport This will backport the following commits from `main` to `8.17`: - [[Obs AI Assistant] fix knowledge base installation state (#206130)](#206130) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sandra G","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T14:38:07Z","message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","ci:cloud-deploy","Team:Obs AI Assistant","ci:project-deploy-elasticsearch","ci:project-deploy-observability","backport:version","v8.18.0","v8.17.1"],"title":"[Obs AI Assistant] fix knowledge base installation state","number":206130,"url":"https://github.com/elastic/kibana/pull/206130","mergeCommit":{"message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206130","number":206130,"mergeCommit":{"message":"[Obs AI Assistant] fix knowledge base installation state (#206130)\n\nResolves https://github.com/elastic/kibana/issues/205970\r\n\r\nUpdates logic to account for knowledge base `/setup` no longer polling\r\nfor model readiness before returning.\r\n\r\n- Currently we only poll `/status` if user manually installs the\r\nknowledge base. In cases where we auto installed, such as after\r\nsuccessfully setting up a connector, we depended on `/setup` to poll\r\ninternally. Since the latter was removed, we need to always poll\r\n`/status`, otherwise user could potentially be in the state where\r\n`setup` has finished (considered installed) but `status` still reports\r\nnot ready and we show the install message again (see screenshots in\r\nhttps://github.com//issues/205970)\r\n- Currently if an install is in progress and user closes the flyout, the\r\nprogress state is lost. These changes should continue to reflect the\r\ninstallation progress in the UI.\r\n- Renames variables and adds comments for easier readability\r\n- adds unit test to component that handles the install UI state,\r\n`WelcomeMessageKnowledgeBase`\r\n\r\n---------\r\n\r\nCo-authored-by: Søren Louv-Jansen <[email protected]>","sha":"06526fe928ac98580e6fe02768b3c403184694f1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/206777","number":206777,"state":"OPEN"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
viduni94
pushed a commit
to viduni94/kibana
that referenced
this issue
Jan 23, 2025
) Resolves elastic#205970 Updates logic to account for knowledge base `/setup` no longer polling for model readiness before returning. - Currently we only poll `/status` if user manually installs the knowledge base. In cases where we auto installed, such as after successfully setting up a connector, we depended on `/setup` to poll internally. Since the latter was removed, we need to always poll `/status`, otherwise user could potentially be in the state where `setup` has finished (considered installed) but `status` still reports not ready and we show the install message again (see screenshots in elastic#205970) - Currently if an install is in progress and user closes the flyout, the progress state is lost. These changes should continue to reflect the installation progress in the UI. - Renames variables and adds comments for easier readability - adds unit test to component that handles the install UI state, `WelcomeMessageKnowledgeBase` --------- Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before migrating to the inference api, the
/setuproute installed the model and polledml.getTrainedModelsonly returning a response when the model was ready (see old code). Since migrating to using the inference endpoint,/setupnow only returns the result from the create inference API and no longer polls for model readiness before returning.When a user does not have a Gen AI connector setup we automatically trigger
/setupafter saving the connector and depended on the polling there. If there is a preconfigured connector, the user manually installs and we poll using/statusinstead. We should poll for/statusin both cases to check for model readiness and not rely on/setupto indicate when the whole installation process is complete.This is causing a UI issue where after
/setupfinishes, they are shown a message that the knowledge base hasn't been setup because/statusreports the model is not ready because it is still being deployed.screenshots of the problem state
Introduced in: #186499
I think it's also causing knowledge base tests to be flaky which still presume it can start using the knowledge base after
/setuphas responded with 200.#205677
#205581
For the knowledge base tests, we'd probably need to add polling to
/status, same as the UI, to check the model is ready so we can start running tests against the knowledge base.The text was updated successfully, but these errors were encountered: