[Serialized state only] Update Library Transforms and Duplicate #206140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/libraryTransforms
…ypes, update controls types
…/libraryTransforms
…/libraryTransforms' into serializedStateOnly/libraryTransforms
…/libraryTransforms
…/libraryTransforms
…/libraryTransforms
nreese
approved these changes
Jan 16, 2025
src/platform/plugins/shared/dashboard/public/dashboard_actions/library_add_action.tsx
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard/public/dashboard_api/load_dashboard_api.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard/public/dashboard_api/panels_manager.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard/public/dashboard_api/panels_manager.ts
Outdated
Show resolved
Hide resolved
ThomThomson
added
release_note:fix
and removed
Feature:Embedding
ThomThomson
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsMetrics [docs]
History
|
dej611
approved these changes
Jan 21, 2025
tonyghiani
approved these changes
Jan 21, 2025
|
@elasticmachine merge upstream |
lukasolson
approved these changes
Jan 21, 2025
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jan 21, 2025
…tic#206140) Unifies the various `LibraryTransforms` interfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state. (cherry picked from commit 3719be0) # Conflicts: # examples/embeddable_examples/public/react_embeddables/saved_book/saved_book_react_embeddable.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ThomThomson
added a commit
that referenced
this pull request
Jan 21, 2025
…#206140) (#207455) # Backport This will backport the following commits from `main` to `8.x`: - [[Serialized state only] Update Library Transforms and Duplicate (#206140)](#206140) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T18:43:43Z","message":"[Serialized state only] Update Library Transforms and Duplicate (#206140)\n\nUnifies the various `LibraryTransforms` interfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state.","sha":"3719be0144d0f5b1fc71d1c564a41446c8ef3133","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","release_note:fix","Team:Presentation","v9.0.0","backport:prev-minor","Feature:Embeddables","project:embeddableRebuild"],"title":"[Serialized state only] Update Library Transforms and Duplicate","number":206140,"url":"https://github.com/elastic/kibana/pull/206140","mergeCommit":{"message":"[Serialized state only] Update Library Transforms and Duplicate (#206140)\n\nUnifies the various `LibraryTransforms` interfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state.","sha":"3719be0144d0f5b1fc71d1c564a41446c8ef3133"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206140","number":206140,"mergeCommit":{"message":"[Serialized state only] Update Library Transforms and Duplicate (#206140)\n\nUnifies the various `LibraryTransforms` interfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state.","sha":"3719be0144d0f5b1fc71d1c564a41446c8ef3133"}}]}] BACKPORT-->
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…tic#206140) Unifies the various `LibraryTransforms` interfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state.
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #205531
Fixes #205824
Note
To fix #205824 I had to change the Links Embeddable to have proper comparators for its various states even when it's by reference. This means that editing a by reference links embeddable will cause
unsaved changesin this PR, and will continue to do so until theunsaved changescalculation is moved over to serialized state only. This is technically incorrect, but I figure this minor bug is a small price to (temporarily) pay, to fix the much larger bug above.Fixes #206316
This PR unifies the various
LibraryTransformsinterfaces, updates all by reference capable embeddables to use them in the same way, and migrates the clone functionality to use only serialized state.Additionally, Dashboard has been changed to properly track and back up changes in the references of its children.