[8.x] [Security Solution][Data Quality Dashboard]: migrate styled-component… (#205559) #206370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#205559) …s to Emotion Addresses elastic#205449 This PR migrates `ecs_data_quality_dashboard` package from `styled-components` to `emotion`. In the process we also convert the `kbn/ui-theme` json tokens to `euiTheme` counterparts. Additionally we decorate root `babel-jest` [transform](https://github.com/kapral18/kibana/blob/211d4a6889f314eb11761b0bc65f7f93d3b55ffd/packages/kbn-test/src/jest/transforms/babel.js) locally in `security_solution/public/overview` and `ecs_data_quality_dashboard` package folder to include `@emotion/babel-preset-css-prop`. The reason for local `babel-jest` transforms is that root `babel-jest` transform doesn't include `@emotion/babel-preset-css-prop` which is necessary for proper compilation of emotion css prop in tests. Without it there is a warning  appearing in every test that tests a component that uses css prop with theme function passed into it. Other use cases seem to be compiling fine without this babel preset. But theme callback is a valid way of using emotion so we shouldn't avoid using it just because it's not added properly to the test compilation step. Hence I am adding it locally to `ecs_data_quality_dashboard` package and `security_solution/public/overview`. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 72980e1) # Conflicts: # x-pack/solutions/security/packages/ecs_data_quality_dashboard/impl/data_quality_panel/mock/test_providers/test_providers.tsx # x-pack/solutions/security/packages/ecs_data_quality_dashboard/tsconfig.json
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
|
KDKHD
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation