[Perfomance] Add is_initial_load meta
#206645
Conversation
kpatticha
added
release_note:skip
| } | ||
|
|
||
| export function measureInteraction() { | ||
| performance.mark(perfomanceMarkers.startPageChange); | ||
| const trackedRoutes: string[] = []; | ||
| const trackedRoutes = new Set<string>(); |
There was a problem hiding this comment.
Q: Do we remove the tracked routes at any point?
Aside from a potential memory leak, what happens if the user goes elsewhere in Kibana and comes back?
Would it be enough if trackedRoutes (Set<string>) is actually currentPathname (string)?
There was a problem hiding this comment.
The trackedRoutes updates with each route change. If the user navigates to another page (e.g., the services page) and then returns, trackedRoutes will be empty.
The objective is to determine whether the current load is due to navigation (an initial load) or a page refresh. Happy to update it if you have a better approach.
Not sure I understand the following, can you explain please
Would it be enough if trackedRoutes (Set) is actually currentPathname (string)?
There was a problem hiding this comment.
Tracking currentPathname or plugin url would be better, see comment.
with the current implementation we don't have a way to distinguish this. There is another EBT metric, kibana_started, which we might be able to correlate with these two events using their timestamps. However, this would require additional analysis work. |
💔 Build Failed
Failed CI StepsHistory
|
There was a problem hiding this comment.
is_initial_load changes with date change because selected time range is persisted via URL state. Also, URL could change even against UI actions which do not cause a data reload.
206645-initial-load-meta-url-issue.mov
See if extracting the plugin url or using pathname is better suited here instead of the full url.
closes https://github.com/elastic/observability-dev/issues/4185
Summary
This PR adds the
is_initial_loadparameter to the meta field to distinguish whether the onPageReady trigger occurs during the initial load or a page refresh.You can find the sample document with the
is_initial_loadmetadata in staging telemetry clusterLink: [DEDUCTED]/s/apm/app/discover#/doc/0d6d7d31-1369-4a53-b36d-fbe97e4e5a0e/backing-ebt-kibana-browser-performance-metrics-000008?id=performance_metric-RMeyhJaNRWamPLvsAPdb4g-2025-01-14T14%3A40%3A50.597Z-kibana%3Aplugin_render_tim
Screen.Recording.2025-01-14.at.19.15.26.mov
How to test
yarn kbn bootstrap