Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] If an index template has a default_pipeline, show a link to it #206923

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jan 16, 2025

Fixes: #183990

Summary

This PR introduces a link in the index template details flyout, directing users to its associated default pipeline, if one is defined.

Screenshot 2025-01-16 at 12 19 49

In order to test this, you can create an index template with the following command:

PUT _index_template/my-template
{
  "index_patterns": ["my-index-*"],
  "template": {
    "settings": {
      "index": {
        "codec": "best_compression",
        "default_pipeline": "my-default-pipeline"
      }
    },
    "mappings": {
      "properties": {
        "field1": {
          "type": "text"
        },
        "field2": {
          "type": "keyword"
        }
      }
    }
  },
  "priority": 100
}

@sabarasaba sabarasaba added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 16, 2025
@sabarasaba sabarasaba self-assigned this Jan 16, 2025
@sabarasaba sabarasaba marked this pull request as ready for review January 16, 2025 13:21
@sabarasaba sabarasaba requested a review from a team as a code owner January 16, 2025 13:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @sabarasaba! Tested locally, changes lgtm!

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #19 / Case View Page observables tab should render the utility bar for the observables table

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 718 720 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 713.2KB 714.0KB +740.0B

History

cc @sabarasaba

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba merged commit 4d539f0 into elastic:main Jan 21, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12883250175

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 21, 2025
… show a link to it (#206923) (#207299)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Management] If an index template has a default_pipeline, show
a link to it (#206923)](#206923)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T08:48:30Z","message":"[Index
Management] If an index template has a default_pipeline, show a link to
it
(#206923)","sha":"4d539f0f5c3abadeba0b8c086a259025f7a4c7fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Index
Management] If an index template has a default_pipeline, show a link to
it","number":206923,"url":"https://github.com/elastic/kibana/pull/206923","mergeCommit":{"message":"[Index
Management] If an index template has a default_pipeline, show a link to
it
(#206923)","sha":"4d539f0f5c3abadeba0b8c086a259025f7a4c7fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206923","number":206923,"mergeCommit":{"message":"[Index
Management] If an index template has a default_pipeline, show a link to
it (#206923)","sha":"4d539f0f5c3abadeba0b8c086a259025f7a4c7fa"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 21, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index management: Link pipeline from index template
4 participants