Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Visualize] Remove duplicate data-render-complete attribute #207100

Closed
wants to merge 2 commits into from

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 17, 2025

Summary

Fixes #207063

Removes the attribute as it is a duplicate because the embeddable is already signalling the render complete event to the panel who's setting the attribute.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Feature:Lens labels Jan 17, 2025
@dej611
Copy link
Contributor Author

dej611 commented Jan 17, 2025

/ci

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 17, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / Journey[data_stress_test_lens_http2] Go to dashboard
  • [job] [logs] FTR Configs #14 / Journey[data_stress_test_lens_http2] Go to dashboard
  • [job] [logs] FTR Configs #77 / Journey[data_stress_test_lens] Go to dashboard
  • [job] [logs] FTR Configs #77 / Journey[data_stress_test_lens] Go to dashboard
  • [job] [logs] FTR Configs #100 / Journey[ecommerce_dashboard_http2] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #100 / Journey[ecommerce_dashboard_http2] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #5 / Journey[ecommerce_dashboard_tsvb_gauge_only] Go to Ecommerce Dashboard with TSVB Gauge only
  • [job] [logs] FTR Configs #5 / Journey[ecommerce_dashboard_tsvb_gauge_only] Go to Ecommerce Dashboard with TSVB Gauge only
  • [job] [logs] FTR Configs #17 / Journey[ecommerce_dashboard] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #17 / Journey[ecommerce_dashboard] Go to Ecommerce Dashboard
  • [job] [logs] FTR Configs #82 / Journey[flight_dashboard] Go to Flights Dashboard
  • [job] [logs] FTR Configs #82 / Journey[flight_dashboard] Go to Flights Dashboard
  • [job] [logs] FTR Configs #90 / Journey[promotion_tracking_dashboard] Wait for visualization animations to finish
  • [job] [logs] FTR Configs #90 / Journey[promotion_tracking_dashboard] Wait for visualization animations to finish
  • [job] [logs] FTR Configs #16 / Journey[web_logs_dashboard_dataview] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #16 / Journey[web_logs_dashboard_dataview] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #99 / Journey[web_logs_dashboard_esql] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #99 / Journey[web_logs_dashboard_esql] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #94 / Journey[web_logs_dashboard] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #94 / Journey[web_logs_dashboard] Go to Web Logs Dashboard
  • [job] [logs] FTR Configs #112 / ObservabilityApp Custom threshold preview chart does render the chart after fixing the error
  • [job] [logs] FTR Configs #112 / ObservabilityApp Custom threshold preview chart does render the chart after fixing the error
  • [job] [logs] FTR Configs #7 / Visualize smoke telemetry tests should render visualization once should correctly render Lens visualization once
  • [job] [logs] FTR Configs #7 / Visualize smoke telemetry tests should render visualization once should correctly render Lens visualization once

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB -25.0B
visualizations 354.2KB 354.2KB -25.0B
total -50.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embeddable] data-render-complete attribute is set both on content and on panel
2 participants