-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.18] [Security Assistant] Fix use default inference endpoint (#212191) #213182
Merged
patrykkopycinski
merged 8 commits into
elastic:8.18
from
kibanamachine:backport/8.18/pr-212191
Mar 8, 2025
Merged
[8.18] [Security Assistant] Fix use default inference endpoint (#212191) #213182
patrykkopycinski
merged 8 commits into
elastic:8.18
from
kibanamachine:backport/8.18/pr-212191
Mar 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Removes internal feature flag responsible for switching to Kibana's internal inference endpoint instead of using a dedicated one. How to test: **Clean cluster:** **1. Setup KB** **2. Make sure the `.kibana-elastic-ai-assistant-knowledge-base-*` Data Stream is using default Inference endpoint** ``` http://localhost:5601/app/management/data/index_management/component_templates/.kibana-elastic-ai-assistant-component-template-knowledge-base ``` <img width="1656" alt="image" src="https://github.com/user-attachments/assets/84fda205-6272-4393-8f7d-a449fae2a090" /> <img width="1086" alt="image" src="https://github.com/user-attachments/assets/19e562ec-da5f-4ec2-ab64-7bfb1d64789c" /> **3. Make sure there is no inference endpoint on the list** <img width="1875" alt="image" src="https://github.com/user-attachments/assets/3465df8b-7c0d-4faf-b113-df897694521e" /> **4. Make sure Security Labs content exists on KB list and you can add and edit Document/Index entry ``` http://localhost:5601/app/management/kibana/securityAiAssistantManagement?tab=knowledge_base ``` Migration: **1. Setup KB on at least 2 Kibana spaces on `main` branch** **2. Switch to this PR's branch and start Kibana** **3. Make sure there is no inference endpoint on the list** ``` http://localhost:5601/app/elasticsearch/relevance/inference_endpoints ``` <img width="1875" alt="image" src="https://github.com/user-attachments/assets/3465df8b-7c0d-4faf-b113-df897694521e" /> **4. Make sure that the Data stream was rolled over** ``` http://localhost:5601/app/management/data/index_management/indices?filter=know&includeHiddenIndices=true ``` Should see two indices per Kibana space: <img width="1741" alt="Zrzut ekranu 2025-03-3 o 15 37 55" src="https://github.com/user-attachments/assets/e6da48c8-59e9-43b8-8eac-c2b5e0059954" /> The older index per space should have mapping: <img width="1083" alt="image" src="https://github.com/user-attachments/assets/01f6e422-77d1-4f8b-8b7e-9c541a7ea47c" /> Newer index per space: <img width="1086" alt="image" src="https://github.com/user-attachments/assets/19e562ec-da5f-4ec2-ab64-7bfb1d64789c" /> **4. Make sure Security Labs content exists on KB list and you can add and edit Document/Index entry ``` http://localhost:5601/app/management/kibana/securityAiAssistantManagement?tab=knowledge_base ``` --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5e742f0)
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.18
:Questions ?
Please refer to the Backport tool documentation