From 4ca9581d0c80db2d7eddeead0471dd0cd48189dd Mon Sep 17 00:00:00 2001 From: Georgiana-Andreea Onoleata Date: Tue, 14 Jan 2025 11:56:40 +0200 Subject: [PATCH 1/3] skipped test after no-floating-promises fixes --- .../apps/cases/group1/view_case.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts b/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts index 66c6a283714b8..e04c6ea2226c5 100644 --- a/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts +++ b/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts @@ -41,7 +41,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { // https://github.com/elastic/kibana/pull/190690 // fails after missing `awaits` were added - describe.skip('View case', () => { + describe('View case', () => { describe('page', () => { createOneCaseBeforeDeleteAllAfter(getPageObject, getService); @@ -581,12 +581,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { expect(await commentArea.getVisibleText()).to.be('Test comment from automation'); }); - /** - * There is this bug https://github.com/elastic/kibana/issues/157280 - * where this test randomly reproduces thus making the test flaky. - * Skipping for now until we fix it. - */ - it.skip('should persist the draft of new comment while description is updated', async () => { + it('should persist the draft of new comment while description is updated', async () => { let commentArea = await find.byCssSelector( '[data-test-subj="add-comment"] textarea.euiMarkdownEditorTextArea' ); @@ -787,6 +782,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { await cases.common.selectSeverity(CaseSeverity.MEDIUM); + await header.waitUntilLoadingHasFinished(); + await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']); await header.waitUntilLoadingHasFinished(); From 1a55f2b8e7e3e10415f0d6265eb6068e66bad896 Mon Sep 17 00:00:00 2001 From: Georgiana-Andreea Onoleata Date: Wed, 15 Jan 2025 11:39:52 +0200 Subject: [PATCH 2/3] fixed custom fields related tests --- .../test/functional_with_es_ssl/apps/cases/group1/view_case.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts b/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts index e04c6ea2226c5..2cc76239d369a 100644 --- a/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts +++ b/x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts @@ -1274,7 +1274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { await header.waitUntilLoadingHasFinished(); }); - afterEach(async () => { + after(async () => { await cases.api.deleteAllCases(); }); From 8b68fbd1c0e360fa5950dc3a0d0829ff80cb11e0 Mon Sep 17 00:00:00 2001 From: Georgiana-Andreea Onoleata Date: Wed, 15 Jan 2025 14:23:29 +0200 Subject: [PATCH 3/3] un-skipped tests in serverless --- .../functional/test_suites/observability/cases/view_case.ts | 6 ++++-- .../functional/test_suites/security/ftr/cases/view_case.ts | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts index f23b2d806ee0a..9556bfa552b80 100644 --- a/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts +++ b/x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts @@ -36,7 +36,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { // https://github.com/elastic/kibana/pull/190690 // fails after missing `awaits` were added - describe.skip('Case View', function () { + describe('Case View', function () { before(async () => { await svlCommonPage.loginWithPrivilegedRole(); }); @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { await cases.common.selectSeverity(CaseSeverity.MEDIUM); + await header.waitUntilLoadingHasFinished(); + await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']); await header.waitUntilLoadingHasFinished(); @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { }); // FLAKY - describe.skip('Lens visualization', () => { + describe('Lens visualization', () => { before(async () => { await cases.testResources.installKibanaSampleData('logs'); await createAndNavigateToCase(getPageObject, getService, owner); diff --git a/x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts b/x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts index eaec4fd9dbaa7..3620ff41281ff 100644 --- a/x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts +++ b/x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts @@ -37,7 +37,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { // https://github.com/elastic/kibana/pull/190690 // fails after missing `awaits` were added - describe.skip('Case View', function () { + describe('Case View', function () { before(async () => { await svlCommonPage.loginWithPrivilegedRole(); }); @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { await cases.common.selectSeverity(CaseSeverity.MEDIUM); + await header.waitUntilLoadingHasFinished(); + await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']); await header.waitUntilLoadingHasFinished(); @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { }); // FLAKY - describe.skip('Lens visualization', () => { + describe('Lens visualization', () => { before(async () => { await cases.testResources.installKibanaSampleData('logs'); await createAndNavigateToCase(getPageObject, getService, owner);