Upgrade EUI to v101 #543
Closed
Upgrade EUI to v101 #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Elastic UI (EUI) library to v101 and updates the TypeScript version while addressing peer dependency issues with the addition of the --legacy-peer-deps flag for npm commands.
- Update npm commands in workflows, RELEASE, and README files to use --legacy-peer-deps.
- Change the EUI theme import in the main App component.
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Updated npm install command to use --legacy-peer-deps |
| RELEASE.md | Updated npm install instructions to use --legacy-peer-deps |
| README.md | Updated npm install commands to use --legacy-peer-deps |
| src/App.tsx | Changed the EUI theme import; verify file path and extension usage |
Files not reviewed (4)
- .buildkite/scripts/package.sh: Language not supported
- .ci/scripts/release-ci.sh: Language not supported
- NOTICE.txt: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/App.tsx:29
- Ensure that the new theme import includes the correct file extension if required (e.g. '.css') by the build configuration; omitting it could lead to runtime errors.
import '@elastic/eui/dist/eui_theme_borealis_light';
Contributor
Author
|
Closing in favor of #548. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an upgrade to the version of EUI.
Also upgrades TypeScript. NOTE this TS upgrade will break peer dependencies for
react-scripts. So far it does not seem like there's any truly negative impact, but we should migrate off ofreact-scriptsat some point if possible and opt for a lower-footprint custom server launch experience. This work has never been explored and is likely not as daunting as it initially sounds.Implementation details
Simply installs some upgrades.
This does now require us to use the
--legacy-peer-depsescape hatch for calls tonpm installornpm cibecause this patch will break peer deps for some older packages that refuse to support TypeScript v5+.How to validate this change