Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #184

Open
andreineculau opened this issue Sep 7, 2024 · 2 comments
Open

Improve testing #184

andreineculau opened this issue Sep 7, 2024 · 2 comments

Comments

@andreineculau
Copy link
Collaborator

I don't know the details, but I have just ran the tests locally bats tests
only to find out that ~/.gitconfig and ~/.gitattributes_global are modified.

@jmurty
Copy link
Collaborator

jmurty commented Sep 9, 2024

Hi @andreineculau I have fixed one potential place where global Git configs could be set by running bats tests/ in commit f88979c.

I'm not sure how your ~/.gitattributes_global file is being modified, the tests should all write directly to a .gitattributes files in the local temporary test directory as set by bats in the envvar $BATS_TEST_DIRNAME.

@andreineculau
Copy link
Collaborator Author

Nice! 🦸

I didn't have time to check, but I have ~/.gitattributes_global set via git config --global core.attributesfile ~/.gitattributes_global and as it happens it's a symlink. Tests were failing because text-replace didn't work on symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants